Rework handle_while #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restioson
added a commit
that referenced
this pull request
Jun 10, 2022
# Conflicts: # examples/interleaved_messages.rs
|
There's also a minor internal spelling error fix in here which can be extracted if needed. |
Restioson
commented
Jun 14, 2022
| @@ -341,12 +343,115 @@ impl<A: Actor> Context<A> { | |||
| let mut addr_recv = addr_rx.recv_async(); | |||
| let mut broadcast_recv = broadcast_rx.recv_async(); | |||
|
|
|||
| loop { | |||
| while self.running == RunningState::Running { | |||
| let (next_msg, unfinished) = { | |||
There was a problem hiding this comment.
This is currently a lot of code duplication, but hopefully if #85 makes it in it should be able to be simplified quite a lot
|
Some tests for |
thomaseizinger
approved these changes
Jun 15, 2022
|
Ready for merge? |
Restioson
added a commit
that referenced
this pull request
Jun 17, 2022
* Remove stopping and repurpose KeepRunning * Fix build - logic will be fixed in #83 * Change stop_all behaviour - in line with stop_self Previously, stop_all would immediately disconnect the address. However, stop_self done on every actor would actually not do this in one case - if there were a free-floating (not executing an actor event loop) Context. This change brings stop_all in line with stop_self. * Fmt + document more breaking changes * merge oversight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
handle_whiletojoin, fixing a potential issue that would cause slight inefficiency if the actor is stopped during handling. It also addsselectas a counterpart, which is likejoinbut will return early if the actor is stopped.