Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for serilog-settings-configuration #58

Closed
RehanSaeed opened this issue Feb 19, 2018 · 4 comments
Closed

Add support for serilog-settings-configuration #58

RehanSaeed opened this issue Feb 19, 2018 · 4 comments
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. help wanted Help wanted from the community.

Comments

@RehanSaeed
Copy link
Owner

I've just realized that our builder code will not work with serilog-settings-configuration. We should additionally provide an overload which works with this package which looks at the parameter names I think, need to investigate more.

cc @krajek

@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. help wanted Help wanted from the community. labels Feb 19, 2018
@krajek
Copy link
Collaborator

krajek commented Feb 21, 2018

I took a quick look and there are two ways in which Serilog.Settings.Configuration can be used.
One is to use the default WithExceptionDetails with no arguments.
Second is to use some class implementing our configuration interface, with default constructor which can be used in the configuration file. Of course, the second method is obscure.

For 4.1 I will prepare a small PR that will expose new API with all available configuration parameters.
I am still not sure if this will allow specifying destructurers in a convenient manner.

@fleed
Copy link

fleed commented Jan 4, 2019

@RehanSaeed @krajek Any progress here?

@RehanSaeed
Copy link
Owner Author

No but we'd be willing to accept a PR for this.

@krajek
Copy link
Collaborator

krajek commented Oct 11, 2019

@RehanSaeed the issue is so old and yet nobody complained. At the time I thought that it would be useful but it seems configuration in code is the standard.

My suggestion: close the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. help wanted Help wanted from the community.
Projects
None yet
Development

No branches or pull requests

3 participants