Optimisation #1: fewer copies, more brain work

Author: DronCode

BMEdit/GameLib/Source/GameLib/Scene/SceneObjectPropertiesLoader.cpp

@@ -97,7 +97,6 @@ namespace gamelib::scene
 		}
 
 		// Read properties
-		Value properties;
 		{
 			const auto& [vRes, _newInstructions] = objectType->verify(ip);
 			if (!vRes)
@@ -112,7 +111,7 @@ namespace gamelib::scene
 				throw SceneObjectVisitorException(objectIdx, "Invalid instructions set (verification failed) [2]");
 			}
 
-			properties = *value;
+			currentObject->getProperties() = *value;
 			ip = newIP; // Assign new ip
 		}
 
@@ -134,8 +133,6 @@ namespace gamelib::scene
 
 		NEXT_IP
 
-		std::map<std::string, Value> controllers;
-
 		if (controllersCount > 0)
 		{
 			for (int32_t controllerIdx = 0; controllerIdx < controllersCount; ++controllerIdx)
@@ -192,7 +189,7 @@ namespace gamelib::scene
 
 				ip = nextIP;
 
-				controllers[controllerName] = controllerMapResult.value();
+				currentObject->getControllers()[controllerName] = controllerMapResult.value();
 
 				if (ip[0].getOpCode() != PRPOpCode::EndObject && reinterpret_cast<const TypeComplex*>(controllerType)->areUnexposedInstructionsAllowed())
 				{
@@ -214,8 +211,9 @@ namespace gamelib::scene
 
 					auto unexposedInstructions = begin.slice(0, ip.size() - endOffset).as<std::vector<PRPInstruction>>();
 
-					auto& orgInstructionsRef = controllers[controllerName].getInstructions();
-					orgInstructionsRef.insert(orgInstructionsRef.end(), unexposedInstructions.begin(), unexposedInstructions.end());
+					//FIXME: Do it better!!!
+//					auto& orgInstructionsRef = controllers[controllerName].getInstructions();
+//					orgInstructionsRef.insert(orgInstructionsRef.end(), unexposedInstructions.begin(), unexposedInstructions.end());
 
 					ip = ip.slice(endOffset, ip.size() - endOffset);
 				}
@@ -229,9 +227,6 @@ namespace gamelib::scene
 			}
 		}
 
-		currentObject->getControllers() = controllers;
-		currentObject->getProperties()  = properties;
-
 		if (parent)
 		{
 			currentObject->setParent(parent);