New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function parameter not used, but logging/Exception says otherwise #131

Open

DominicCronin opened this issue Sep 10, 2020 · 0 comments

DominicCronin commented Sep 10, 2020

https://github.com/sdl/dxa-web-application-java/blob/05cb742c88d819310ee029702f440ee2ecf45c4d/dxa-framework/dxa-common-api/src/main/java/com/sdl/webapp/common/controller/BaseController.java#L67

In getEntityFromRequest, the entityId parameter only gets used in what is then presumably a misleading log message and Exception

The same pattern is also to be seen in getRegionFromRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment