Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring]: Hardwiring of light information in LightSyntax #5257

Open
cwisniew opened this issue Feb 14, 2025 · 0 comments
Open

[Refactoring]: Hardwiring of light information in LightSyntax #5257

cwisniew opened this issue Feb 14, 2025 · 0 comments
Assignees
Labels
feature Adding functionality that adds value

Comments

@cwisniew
Copy link
Member

Describe the problem

Hardwiring of light information in LightSyntax

for (Light light : lightSource.getLightList()) {
final var parameters = new HashMap<>();
// TODO: This HAS to change, the lights need to be auto describing, this hard wiring sucks
if (lightSource.getType() == LightSource.Type.AURA) {
parameters.put("GM", light.isGM());
parameters.put("OWNER", light.isOwnerOnly());
}
parameters.put("IGNORES-VBL", lightSource.isIgnoresVBL());
parameters.put("", light.getShape().name().toLowerCase());

The improvement you'd like to see

Remove hardwiring of light information in LightSyntax

Expected Benefits

Flexibility

Additional Context

No response

@cwisniew cwisniew added the feature Adding functionality that adds value label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

No branches or pull requests

2 participants