Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring]: Remove the TokenPanelChanged event #5253

Open
cwisniew opened this issue Feb 14, 2025 · 0 comments
Open

[Refactoring]: Remove the TokenPanelChanged event #5253

cwisniew opened this issue Feb 14, 2025 · 0 comments
Assignees
Labels
code-maintenance Adding/editing javadocs, unit tests, formatting.

Comments

@cwisniew
Copy link
Member

Describe the problem

Remove the TokenPanelChanged Event

/*
* This software Copyright by the RPTools.net development team, and
* licensed under the Affero GPL Version 3 or, at your option, any later
* version.
*
* MapTool Source Code is distributed in the hope that it will be
* useful, but WITHOUT ANY WARRANTY; without even the implied warranty
* of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*
* You should have received a copy of the GNU Affero General Public
* License * along with this source Code. If not, please visit
* <http://www.gnu.org/licenses/> and specifically the Affero license
* text at <http://www.gnu.org/licenses/agpl.html>.
*/
package net.rptools.maptool.model.tokens;
import net.rptools.maptool.model.Token;
// TODO Get rid of this event. Panels can just listen for token changes rather than having callers
// guess whether an update is needed.
public record TokenPanelChanged(Token token) {}

The improvement you'd like to see

Remove the TokenPanelChanged event

Expected Benefits

Clearer code

Additional Context

No response

@cwisniew cwisniew added the code-maintenance Adding/editing javadocs, unit tests, formatting. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-maintenance Adding/editing javadocs, unit tests, formatting.
Projects
None yet
Development

No branches or pull requests

2 participants