Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecau): upstream provider fixes #786

Merged
merged 2 commits into from
Jul 27, 2024
Merged

fix(ecau): upstream provider fixes #786

merged 2 commits into from
Jul 27, 2024

Conversation

ROpdebee
Copy link
Owner

Fixed:

Unfixed:

  • DatPiff is dead, has been for a while, and although their new homepage implies they'll come back at some point, the site will likely be different entirely, and might not have the same content. However, I'm keeping the provider around for now because we might be able to rewrite the links to use the Internet Archive and download the cover art from old archived snapshots instead.

Fixes #727.

ROpdebee added 2 commits July 27, 2024 17:27
@ROpdebee
fix(ecau): fix YT Music cover extraction
72707d3
@ROpdebee
fix(ecau): fix Audible audiobook cover extraction (again)
8112d91 
We now use the same extraction logic as the other pages, so the
implementation is also severely simplified.

Also update another test case since the upstream page has changed.
We're changing it to a different release because we need to test
whether we can extract multiple images too, and the new upstream
only has one.
@ROpdebee ROpdebee added bug Something isn't working mb_enhanced_cover_art_uploads labels Jul 27, 2024
@ROpdebee ROpdebee mentioned this pull request Jul 27, 2024
Merged
@ROpdebee ROpdebee merged commit dff1233 into main Jul 27, 2024
11 checks passed
@github-actions GitHub Actions
Copy link

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2024.7.27.3 in 77266c0

github-actions bot added a commit that referenced this pull request Jul 27, 2024
@github-actions
🤖 mb_enhanced_cover_art_uploads 2024.7.27.3
77266c0 
fix(ecau): upstream provider fixes (#786)
@ROpdebee ROpdebee mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working deploy:success mb_enhanced_cover_art_uploads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-record PollyJS HTTP recordings
1 participant
@ROpdebee