feat(ecau): add YouTube and YouTube Music provider #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROpdebee
changed the title
Test case for 404 releases is currently disabled because the test bumps into a consent page.
ROpdebee
force-pushed
the
ecau-yt-music
branch
from
462f208 to
a725f61
Compare
|
🚀 Released 1 new userscript version(s):
|
github-actions bot
added a commit
that referenced
this pull request
Dec 22, 2023
feat(ecau): add YouTube and YouTube Music provider (#724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTube
Quite straightforward, but the test case for 404 releases is disabled because the tests runs into a consent page, which fails. We also have to make sure to pass a language in the URL to make sure we get the 404 text in English.
The cover art URL is actually deterministic, we can just construct it from the video ID. However, we still use the normal
HeadMetaPropertyProviderso that we can check the existence of the release before attempting to load the cover.Closes #722.
YouTube Music
The information we need is embedded in encoded JSON in the web source, so we extract and decode it.
Supports both
/browse/and/playlist?list=URLs, the former redirects to the latter in the browser so we need to support both. However,/playlist?list=can also point to actual playlists, not albums, which we reject.Also supports
/watch?v=URLs, which get dispatched to the normal YouTube provider.Closes #723.