fix(ecau): copy MusicBrainz complex artwork types #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROpdebee
force-pushed
the
ecau-fix-mb-raw-type
branch
from
ca1e9f5 to
c1fdc04
Compare
|
/deploy-preview |
|
This PR changes 1 built userscript(s):
|
github-actions bot
added a commit
that referenced
this pull request
Dec 1, 2023
fix(ecau): copy MusicBrainz complex artwork types (#716)
"Matrix/Runout" and "Raw/Unedited" could not be copied when a MB release's images were copied because the enum used the "Matrix" and "Raw" keys only. Instead, we'll use the full artwork type name as keys. This also requires changes in VGMdb's caption to artwork type mappings and related tests. Also add test case with a real release.
ROpdebee
force-pushed
the
ecau-fix-mb-raw-type
branch
from
c1fdc04 to
ed07226
Compare
|
🚀 Released 1 new userscript version(s):
|
github-actions bot
added a commit
that referenced
this pull request
Dec 2, 2023
fix(ecau): copy MusicBrainz complex artwork types (#716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Matrix/Runout" and "Raw/Unedited" could not be copied when a MB release's images were copied because the enum used the "Matrix" and "Raw" keys only. Instead, we'll use the full artwork type name as keys. This also requires changes in VGMdb's caption to artwork type mappings and related tests. Also add test case with a real release.
Fixes #708