fix(ecau): retry loading image contents on certain HTTP errors #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROpdebee
force-pushed
the
ecau-retry-429
branch
2 times, most recently
from
3c45423 to
63fd7f8
Compare
Discogs has started to rate-limit image requests. Adding a retry-loop with exponential backoff on 429/5xx HTTP errors should alleviate most of these issues, and will work for other providers too. Manually tested on a release with 47 Discogs images. 5 retries is not enough, but 10 seems to work.
And fix bug.
github-actions bot
added a commit
that referenced
this pull request
Jun 8, 2023
fix(ecau): retry loading image contents on certain HTTP errors (#669)
|
🚀 Released 1 new userscript version(s):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discogs has started to rate-limit image requests. Adding a retry-loop with exponential backoff on 429/5xx HTTP errors should alleviate most of these issues, and will work for other providers too.
Manually tested on a release with 47 Discogs images. 5 retries is not enough, but 10 seems to work.
Fixes #668.