Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecau): add Booth.pm provider #663

Merged
merged 5 commits into from
Apr 23, 2023
Merged

feat(ecau): add Booth.pm provider #663

merged 5 commits into from
Apr 23, 2023

Conversation

ROpdebee
Copy link
Owner

Fixes #660.

We shouldn't throw an error here and instead return an empty array.
We also don't throw errors in Deezer or Datpiff releases if they
use placeholder images.
API > HTML because of potential page changes. It'll also make it
easier to support shop subdomains.
@ROpdebee
Copy link
Owner Author

We should probably squash this one when merging, primarily because of the page HTML responses included in earlier commits that are now replaced by a (much smaller) JSON.

@ROpdebee ROpdebee merged commit 6ea98b3 into main Apr 23, 2023
@ROpdebee ROpdebee deleted the provider-booth branch April 23, 2023 13:09
@github-actions
Copy link

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2023.4.23.3 in 48df613

github-actions bot added a commit that referenced this pull request Apr 23, 2023
feat(ecau): add Booth.pm provider (#663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Booth.pm
1 participant