Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecau): provider fixes for Soundcloud, Amazon Music #653

Merged
merged 3 commits into from
Apr 22, 2023
Merged

fix(ecau): provider fixes for Soundcloud, Amazon Music #653

merged 3 commits into from
Apr 22, 2023

Conversation

ROpdebee
Copy link
Owner

  • Fix detection of Amazon digital music pages (only used to raise a more specific error)
  • Fix extraction of Soundcloud sets: Update client ID

Fixes #621

@ROpdebee ROpdebee added mb_enhanced_cover_art_uploads bug Something isn't working labels Apr 22, 2023
@codecov
Copy link

codecov bot commented Apr 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4ef865f) 98.33% compared to head (bd1eeca) 98.33%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          58       58           
  Lines        1384     1384           
  Branches      222      222           
=======================================
  Hits         1361     1361           
  Misses         15       15           
  Partials        8        8
Impacted Files Coverage Δ
.../mb_enhanced_cover_art_uploads/providers/amazon.ts 93.44% <100.00%> (ø)
...enhanced_cover_art_uploads/providers/soundcloud.ts 89.39% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

ROpdebee added 3 commits April 22, 2023 18:37
@ROpdebee
test(utils): add fake user agent to recorded GMXHR requests
1ef01f6 
Amazon was blocking the requests from the tests because the adapter
wasn't sending a browser user agent. Adding the fake user agent fixes
this. It doesn't matter for production versions or during replayed
testing, but it blocked regenerating HTTP recordings.
@ROpdebee
fix(ecau): fix detection of Amazon digital music pages
c956467
@ROpdebee
fix(ecau): update Soundcloud app ID
bd1eeca
@ROpdebee ROpdebee force-pushed the regenerate-polly-recordings branch from c51b31d to bd1eeca Compare April 22, 2023 16:37
@ROpdebee ROpdebee merged commit 46e7e95 into main Apr 22, 2023
@ROpdebee ROpdebee deleted the regenerate-polly-recordings branch April 22, 2023 16:44
@github-actions
Copy link

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2023.4.22 in 0f98270

github-actions bot added a commit that referenced this pull request Apr 22, 2023
@github-actions
🤖 mb_enhanced_cover_art_uploads 2023.4.22
0f98270 
fix(ecau): provider fixes for Soundcloud, Amazon Music (#653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working deploy:success mb_enhanced_cover_art_uploads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-record PollyJS HTTP recordings
1 participant
@ROpdebee