Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecau): don't use Promise#finally. #542

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

ROpdebee
Copy link
Owner

@ROpdebee ROpdebee commented Aug 3, 2022

Promise#finally isn't supported in all browsers which we claim to support, so we'll use a polyfill instead of using it directly.

Closes #537.

Promise#finally isn't supported in all browsers which we claim to
support, so we'll use a polyfill instead of using it directly.
@ROpdebee ROpdebee added bug Something isn't working mb_enhanced_cover_art_uploads labels Aug 3, 2022
@ROpdebee
Copy link
Owner Author

ROpdebee commented Aug 3, 2022

/deploy-preview for testing.

github-actions bot added a commit that referenced this pull request Aug 3, 2022
fix(ecau): don't use Promise#finally. (#542)
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

This PR changes 1 built userscript(s):

See all changes

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #542 (b442936) into main (c8d33a9) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   99.55%   99.17%   -0.38%     
==========================================
  Files          57       57              
  Lines        1335     1341       +6     
  Branches      209      212       +3     
==========================================
+ Hits         1329     1330       +1     
- Misses          6        8       +2     
- Partials        0        3       +3     
Impacted Files Coverage Δ
src/lib/util/async.ts 100.00% <100.00%> (ø)
src/lib/util/observable.ts 100.00% <100.00%> (ø)
...rc/mb_enhanced_cover_art_uploads/providers/base.ts 96.42% <0.00%> (-3.58%) ⬇️
src/mb_enhanced_cover_art_uploads/fetch.ts 96.70% <0.00%> (-3.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d33a9...b442936. Read the comment docs.

@ROpdebee ROpdebee merged commit a351eb8 into main Aug 3, 2022
@ROpdebee ROpdebee deleted the ecau-finally-polyfill branch August 3, 2022 17:40
github-actions bot added a commit that referenced this pull request Aug 3, 2022
fix(ecau): don't use Promise#finally. (#542)
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2022.8.3.2 in a1f3c6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MB: Enhanced Cover Art Uploads | t.finally is not a function | Waterfox 2022.06
1 participant