Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecau): improve VGMdb caption mapping #535

Merged
merged 1 commit into from
Jul 28, 2022
Merged

fix(ecau): improve VGMdb caption mapping #535

merged 1 commit into from
Jul 28, 2022

Conversation

ROpdebee
Copy link
Owner

  • More whitespace trimming
  • Support colons to separate type from comment
  • Map disc matrix/runout types
  • Map packaging top/bottom types
  • Improved mapping of digipak/slipcase faces
  • More edge cases
  • Include medium type for discs with sequence numbers

https://community.metabrainz.org/t/ropdebees-userscripts-support-thread/551947/94?u=ropdebee

* More whitespace trimming
* Support colons to separate type from comment
* Map disc matrix/runout types
* Map packaging top/bottom types
* Improved mapping of digipak/slipcase faces
* More edge cases
* Include medium type for discs with sequence numbers
@ROpdebee ROpdebee added bug Something isn't working mb_enhanced_cover_art_uploads labels Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #535 (d0e38e8) into main (a5bfdb4) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
- Coverage   99.77%   99.55%   -0.23%     
==========================================
  Files          57       57              
  Lines        1308     1335      +27     
  Branches      204      209       +5     
==========================================
+ Hits         1305     1329      +24     
- Misses          3        6       +3     
Impacted Files Coverage Δ
...c/mb_enhanced_cover_art_uploads/providers/vgmdb.ts 100.00% <100.00%> (ø)
src/lib/util/array.ts 83.33% <0.00%> (-16.67%) ⬇️
src/mb_enhanced_cover_art_uploads/fetch.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5bfdb4...d0e38e8. Read the comment docs.

@ROpdebee
Copy link
Owner Author

#yolo once more.

@ROpdebee ROpdebee merged commit c8d33a9 into main Jul 28, 2022
github-actions bot added a commit that referenced this pull request Jul 28, 2022
fix(ecau): improve VGMdb caption mapping (#535)
@github-actions
Copy link

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2022.7.28.6 in 47ea7f2

@ROpdebee ROpdebee deleted the ecau-vgmdb-types branch August 8, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant