Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecau): include full URL in logging messages #402

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Conversation

ROpdebee
Copy link
Owner

Many providers return nonsensical image names, so the logging messages
weren't really informative. We now have some more real estate in the
logging display, so we may as well show the full URL everywhere.

Many providers return nonsensical image names, so the logging messages
weren't really informative. We now have some more real estate in the
logging display, so we may as well show the full URL everywhere.
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #402 (3c706b1) into main (9c3c510) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          44       44           
  Lines        1001     1003    +2     
  Branches      168      168           
=======================================
+ Hits         1000     1002    +2     
  Partials        1        1           
Impacted Files Coverage Δ
src/lib/util/urls.ts 100.00% <100.00%> (ø)
src/mb_enhanced_cover_art_uploads/fetch.ts 100.00% <100.00%> (ø)
...b_enhanced_cover_art_uploads/providers/7digital.ts 100.00% <100.00%> (ø)
...mb_enhanced_cover_art_uploads/providers/datpiff.ts 100.00% <100.00%> (ø)
.../mb_enhanced_cover_art_uploads/providers/amazon.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3c510...3c706b1. Read the comment docs.

@ROpdebee ROpdebee merged commit 40675ed into main Jan 27, 2022
@ROpdebee ROpdebee deleted the ecau-logging-url branch January 27, 2022 15:31
github-actions bot added a commit that referenced this pull request Jan 27, 2022
feat(ecau): include full URL in logging messages (#402)
@github-actions
Copy link

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2022.1.27.5 in 5d1ab64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants