perf(ecau): refactor sync generators to prevent babel regenerator

[ROpdebee]

Fixes #399.

[codecov]

Codecov Report

Merging #401 (49e3ce5) into main (19ad96d) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main     #401      +/-   ##
===========================================
- Coverage   100.00%   99.90%   -0.10%     
===========================================
  Files           44       44              
  Lines          995     1002       +7     
  Branches       167      168       +1     
===========================================
+ Hits           995     1001       +6     
- Partials         0        1       +1     

Impacted Files	Coverage Δ
src/lib/util/array.ts	100.00% <100.00%> (ø)
src/mb_enhanced_cover_art_uploads/fetch.ts	100.00% <100.00%> (ø)
src/mb_enhanced_cover_art_uploads/maximise.ts	97.77% <0.00%> (-2.23%)	⬇️
src/lib/util/urls.ts	100.00% <0.00%> (ø)
.../mb_enhanced_cover_art_uploads/providers/amazon.ts	100.00% <0.00%> (ø)
...mb_enhanced_cover_art_uploads/providers/discogs.ts	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ad96d...49e3ce5. Read the comment docs.

[kellnerd]

The alternative would be to use Array.forEach() which also provides the index to its callback function. That would be doable for our current use case, but it's not always feasible to use a callback function instead of an inline loop.

[ROpdebee]

That would be doable for our current use case

It wouldn't preserve the current semantics, since there's async stuff going on in the loop body. While we could use Array.map with Promise.all, that would lead to multiple images being fetched in parallel and the log messages showing up out-of-order. That could still be acceptable though. Since we're trying to prevent duplicate images, we can't fetch them in parallel as that could lead to race conditions.

Speaking of Array.map, why am I not just doing return array.map((el, idx) => [el, idx])? 🤔

[kellnerd]

You are right, I had missed the await keyword.

[github-actions]

🚀 Released 1 new userscript version(s):

• mb_enhanced_cover_art_uploads 2022.1.27.4 in 7f0fdf6