feat(ecau): support RateYourMusic single URLs #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 899 899
Branches 157 157
=========================================
Hits 899 899
Continue to review full report at Codecov.
|
kellnerd
approved these changes
Dec 22, 2021
github-actions bot
added a commit
that referenced
this pull request
Dec 22, 2021
feat(ecau): support RateYourMusic single URLs (#336)
|
🚀 Released 1 new userscript version(s):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329.
This ran 715 test cases on my machine, so CI should do the same. Does it though?It does, ignore me, I got confused as I only added two URL test cases but of course each URL tests translates into 3 smaller test cases (matching, ID extraction, and checking the dispatch map) 🤦♂️