fix(caa upload): prevent processing URL if it's already in progress #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #196 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 35 35
Lines 770 770
Branches 139 139
=========================================
Hits 770 770 Continue to review full report at Codecov.
|
kellnerd
approved these changes
Oct 31, 2021
There was a problem hiding this comment.
Helps against double clicking an import button (tested with the Discogs provider).
Previously this queued the images (or most of them) twice and failed to generate an edit note body (only the footer was there). With the changes it only queues the images once and successfully generates an edit note body (as it does for a single click).
github-actions bot
added a commit
that referenced
this pull request
Oct 31, 2021
fix(caa upload): prevent processing URL if it's already in progress (#196)
|
🚀 Released 1 new userscript version(s):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May close #193
In older versions, spam-clicking the provider button will lead to the same URL being processed multiple times, and possibly enqueued multiple times too, depending on the interleaving of certain async operations. To prevent this, we're now keeping a set of URLs which are currently in progress, and skip all processing of a URL entirely if it's already being processed.