-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(caa upload): support missing Amazon TLDs #190
Conversation
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 35 35
Lines 768 770 +2
Branches 139 139
=========================================
+ Hits 768 770 +2
Continue to review full report at Codecov.
|
We might as well. Not sure what I based myself on when initially adding the Amazon provider, I guess MB source code? Couple of requests:
|
Not all amazon.* domains have music.amazon.* equivalents, those seem to exist only for countries where Amazon Music Prime is available. See https://en.wikipedia.org/wiki/Amazon_Music#Country_Availability
9c39431
to
cede64b
Compare
Ok, I have added the missing Amazon domains and added a TLD exception for Adding all of these to Amazon Music too does not seem to be a good idea: While |
feat(caa upload): support missing Amazon TLDs (#190)
🚀 Released 1 new userscript version(s):
|
Closes #189.
Trivial fix, tested with the release which is linked via the reported issue.
Should we also add all of the remaining domains which are listed on Wikipedia or should we wait until someone explicitly requests them?