Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(caa upload): add Melon provider #164

Merged
merged 1 commit into from
Oct 24, 2021
Merged

feat(caa upload): add Melon provider #164

merged 1 commit into from
Oct 24, 2021

Conversation

ROpdebee
Copy link
Owner

@ROpdebee ROpdebee commented Oct 24, 2021

Pretty standard provider, with one exception: We need to override cleanUrl as its IDs are in the query params.

Closes #78

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #164 (db406e5) into main (9c4c993) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        33    +1     
  Lines          693       699    +6     
  Branches       128       128           
=========================================
+ Hits           693       699    +6     
Impacted Files Coverage Δ
...c/mb_enhanced_cover_art_uploads/providers/index.ts 100.00% <100.00%> (ø)
...c/mb_enhanced_cover_art_uploads/providers/melon.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4c993...db406e5. Read the comment docs.

Copy link
Collaborator

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not much to say here 🚢

@ROpdebee ROpdebee force-pushed the ecau-melon-provider branch from 362ec22 to db406e5 Compare October 24, 2021 11:58
@ROpdebee ROpdebee merged commit 9536ea5 into main Oct 24, 2021
@ROpdebee ROpdebee deleted the ecau-melon-provider branch October 24, 2021 12:02
github-actions bot added a commit that referenced this pull request Oct 24, 2021
feat(caa upload): add Melon provider (#164)
@github-actions
Copy link

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2021.10.24 in 759f09a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New provider: Melon
2 participants