Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caa upload): don't show "or" if there are no provider buttons #156

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

ROpdebee
Copy link
Owner

@ROpdebee ROpdebee commented Oct 22, 2021

  • Add but hide "or" by default.
  • When a button is added, show the "or".

Closes #150.
Tested manually on https://beta.musicbrainz.org/release/b4166c32-aacf-4ada-896a-587366456cec/add-cover-art (should not show "or") and https://beta.musicbrainz.org/release/87970743-bcf7-460e-abc7-1a942a4457fe/add-cover-art (should show "or").

@ROpdebee ROpdebee added bug Something isn't working mb_enhanced_cover_art_uploads labels Oct 22, 2021
@ROpdebee ROpdebee requested a review from kellnerd October 22, 2021 15:37
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #156 (94b779f) into main (0ef7043) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          611       611           
  Branches       112       112           
=========================================
  Hits           611       611           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef7043...94b779f. Read the comment docs.

@kellnerd
Copy link
Collaborator

/deploy-preview please because I am lazy

@github-actions
Copy link

This PR changes 1 built userscript(s):

See all changes

github-actions bot added a commit that referenced this pull request Oct 22, 2021
fix(caa upload): don't show "or" if there are no provider buttons (#156)
Copy link
Collaborator

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, testing has never been easier. Delegate building to the bot, click the install link and open the two test releases 🚀

@ROpdebee ROpdebee merged commit b66b9a9 into main Oct 22, 2021
@ROpdebee ROpdebee deleted the ecau-trailing-or branch October 22, 2021 16:02
github-actions bot added a commit that referenced this pull request Oct 22, 2021
fix(caa upload): don't show "or" if there are no provider buttons (#156)
@github-actions
Copy link

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2021.10.22.2 in 557672e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECAU places the "or" even if no provider buttons are added
2 participants