fix(caa upload): accept dirty Amazon URL without trailing slash

ROpdebee · Oct 19, 2021 · af5a998 · af5a998
1 parent 542dfc1
commit af5a998
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/mb_enhanced_cover_art_uploads/providers/amazon.ts b/src/mb_enhanced_cover_art_uploads/providers/amazon.ts
@@ -35,7 +35,7 @@ export class AmazonProvider extends CoverArtProvider {
     }
 
     name = 'Amazon';
-    urlRegex = /\/(?:gp\/product|dp)\/([A-Za-z0-9]{10})(?:\/|$)/;
+    urlRegex = /\/(?:gp\/product|dp)\/([A-Za-z0-9]{10})(?:\/|\?|$)/;
 
     async findImages(url: URL): Promise<CoverArt[]> {
         const pageContent = await this.fetchPage(url);

diff --git a/tests/mb_enhanced_cover_art_uploads/providers/amazon.test.ts b/tests/mb_enhanced_cover_art_uploads/providers/amazon.test.ts
@@ -10,6 +10,7 @@ describe('amazon provider', () => {
 
     const urlCases = [
         ['dirty URL', 'https://www.amazon.com/Pattern-Seeking-Animals/dp/B07RZ2T9F1/ref=tmm_acd_swatch_0?_encoding=UTF8&qid=&sr=', 'B07RZ2T9F1'],
+        ['dirty URL without trailing slash', 'https://www.amazon.com/Chronicles-Narnia-Collectors-Radio-Theatre/dp/1624053661?qsid=145-0543367-7486236', '1624053661'],
         ['dp URL', 'https://www.amazon.com/dp/B07RZ2T9F1', 'B07RZ2T9F1'],
         ['gp URL', 'https://www.amazon.com/gp/product/B07RZ2T9F1', 'B07RZ2T9F1'],
     ];