Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling gfx1031 #1511

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Enabling gfx1031 #1511

merged 2 commits into from
Sep 16, 2022

Conversation

littlewu2508
Copy link
Contributor

This commit enables benchmarking and compiling kernels for gfx1031 target

@littlewu2508 littlewu2508 mentioned this pull request May 19, 2022
Closed
@benjaminulmer benjaminulmer added the NoCI Don't run CI label Jun 8, 2022
@cgmb cgmb requested a review from benjaminulmer July 8, 2022 04:29
@benjaminulmer
Copy link
Contributor

Hi @littlewu2508
Sorry this has taken so long to get to. I updated the PR to address the conflicts with the addition of gfx11 series support. Please look this over to make sure everything still looks good to you. Assuming this goes through our CI checks, this PR should be good to merge.

@benjaminulmer benjaminulmer removed the NoCI Don't run CI label Jul 11, 2022
@DorianRudolph DorianRudolph mentioned this pull request Jul 28, 2022
Closed
@cgmb
Copy link
Contributor

cgmb commented Sep 13, 2022

@benjaminulmer, what is this waiting for?

@littlewu2508
Copy link
Contributor Author

Hi @littlewu2508 Sorry this has taken so long to get to. I updated the PR to address the conflicts with the addition of gfx11 series support. Please look this over to make sure everything still looks good to you. Assuming this goes through our CI checks, this PR should be good to merge.

Sorry I forgot to take a look. It seems no problem since my change is quite simple.

@benjaminulmer benjaminulmer merged commit a889a79 into ROCm:develop Sep 16, 2022
@cgmb cgmb mentioned this pull request Sep 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminulmer benjaminulmer benjaminulmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littlewu2508 @benjaminulmer @cgmb