examples:rpl_udp removed the limit of 5 characters as payload size #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BytesGalore
added
Type: enhancement
BytesGalore
force-pushed
the
rpl_udp_send_buffer
branch
from
0eab660 to
b9e5c94
Compare
|
|
||
| if (argc != 3) { | ||
| printf("usage: send <addr> <text>\n"); | ||
| return 1; | ||
| } | ||
|
|
||
| address = atoi(argv[1]); | ||
| /* max payload size = MTU - MAC - AES - IPV6_HDR_LEN - UDP_HDR_LEN | ||
| * 33 = 127 - 25 - 21 - 40 - 8 |
There was a problem hiding this comment.
Isn't your calculation based on the 802.15.4 MTU? Using this example e.g. via ethernet and ipv6 would yield room for a far bigger payload size
There was a problem hiding this comment.
yup, but I thought that the minimal average is most suiting here since the example should be runnable on every supported hardware
There was a problem hiding this comment.
I guess we can live with the minimal average (:
There was a problem hiding this comment.
The minimal average would be the cc1100 with 58, but since this is smaller than 0 with above calculation, I guess we are okay :D
There was a problem hiding this comment.
Don't we have fragmentation for that?
|
kicked travis |
|
travis is happy. GO |
cgundogan
added a commit
that referenced
this pull request
Mar 31, 2015
examples:rpl_udp removed the limit of 5 characters as payload size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer size for sending a text to a node via UDP was limited to 5.
This PR rises the limit to 33 bytes since it is the maximum payload we can offer to be sent without fragmenting packets:
MTU - MAC Header - Encryption Header - IPV6 Header - UDP Header