Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

driver: RIOT port for the Freescale kw2x radio #2329

Closed
wants to merge 16 commits into from
Closed

driver: RIOT port for the Freescale kw2x radio #2329

wants to merge 16 commits into from

Conversation

jonas-rem
Copy link
Contributor

This PR adds support for Freescale KW2x radio. The driver uses the new netdev interface exclusively, the old transceiver interface is not supported.

For the use with: MKW24D512, MKW22D512, MKW21D512, and
MKW21D256

This PR depends on #2059, #2265 and #2188.

@jfischer-no jfischer-no added Area: drivers Area: Device drivers State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet State: waiting for other PR State: The PR requires another PR to be merged first Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jan 20, 2015
@jfischer-no jfischer-no mentioned this pull request Jan 20, 2015
Merged
@thomaseichinger thomaseichinger self-assigned this Jan 20, 2015
thomaseichinger
thomaseichinger reviewed Jan 21, 2015
View reviewed changes
drivers/include/kw2xrf.h
extern netdev_t kw2xrf_netdev;



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many newlines.

@jonas-rem
Copy link
Contributor Author

@haukepetersen Thanks for you comments! Indeed the IRQ-disabling is not neccessary and was ment for testing purposes. I addressed you comments accordingly and will updated the PR later this day.

There is an other question at the moment. So far, I only tested the driver with the /tests/netdev test.
It would be important for us to have a working rpl-udp demo. In the Virtual meeting two weeks ago, we already discussed on this plan shortly. My conclusion was that it is possible with the PR "transceiver: netapi adapter #1969" to use the existing (old) network stack in combination with the new network device (this radio driver).

  1. Is this assumption correct in general?
  2. What steps would be neccessary to make the rpl_udp example runnable with the kw2x-rf radio driver?
  3. As is saw it, the default transceiver has to be defined in transceiver.h even through the transceiver interface is not used anymore?

Sry about my confusion.

@haukepetersen
Copy link
Contributor

@jremmert-phytec-iot The netdev (and netapi) are currently under heavy construction, and I honestly doubt we will get them stable before Embedded world... I personally do not know much about the netapi adapter, maybe @authmillenon can shed some light on this?

As a short-term solution towards the Embedded World I would probably suggest to implement the old transceiver interface for you radio. Although it will be thrown out at some point, you can run the current network stack (and the rpl_udp demo) with it. Also implementing this should only take a day or two...

@jonas-rem
Copy link
Contributor Author

Ok, im currently in the process of adaption. Your right, that might be the savest option to get a stable demo.

I think I missunderstood the netdev-adapter and the last days I couln't figure out how it works.

jonas-rem and others added 16 commits February 10, 2015 15:20
@jonas-rem
initial import of adapted kw2xrf-radio driver with the use of netdev-…
7d13f96 
…interface
@jonas-rem
comments addressed, cleaned up
dc16a28
@jonas-rem
comments addressed
a9b2d82
@jonas-rem
return values consistently changed to 0 on success
0d9cb7f
@jonas-rem
improvement/bugfix: added higher layer headers to tx packet
dbddb47
@jonas-rem
comments addressed 2
473d717
@jfischer-no @jonas-rem
drivers/kw2xrf: adopt for old transceiver interface
5f790b2
@jfischer-no @jonas-rem
sys/shell/commands: add kw2xrf transceiver
9a604b5
@jfischer-no @jonas-rem
drivers/include/netdev/default.h: fix typo
fba77b3
@jfischer-no @jonas-rem
sys: add kw2xrf transceiver support
b1c218a
@jfischer-no @jonas-rem
examples/default/main.c: add kw2xrf transceiver support
d5614e1
@jfischer-no @jonas-rem
sys/net/ccn_lite: add kw2xrf transceiver support
2534394
@jfischer-no @jonas-rem
tests/net_if/main.c: add kw2xrf transceiver support
c6bbe93
@jfischer-no @jonas-rem
drivers/kw2xrf/kw2xrf_rx.c: refactor debug and receive code
de2cd75
@jonas-rem
seperated public transceiver-if and private function prototypes
110c788
@jonas-rem
squash: cleaned up tx file
8a3920a
@jonas-rem
Copy link
Contributor Author

Adapted to Transceiver interface and rebased.

@jfischer-no jfischer-no mentioned this pull request Mar 3, 2015
Closed
@OlegHahm OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01
@jonas-rem jonas-rem mentioned this pull request Apr 2, 2015
Merged
@jonas-rem jonas-rem closed this Apr 2, 2015
@jonas-rem
Copy link
Contributor Author

Closed due to refactoring and reimplementation in #2756.

@jonas-rem jonas-rem deleted the pr@kw2x-rf branch May 17, 2015 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomaseichinger thomaseichinger

Labels
Area: drivers Area: Device drivers Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR State: waiting for other PR State: The PR requires another PR to be merged first State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonas-rem @thomaseichinger @jfischer-no @haukepetersen