sys/test_utils/dummy_thread: initial commit #14227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
added
Area: tests
kaspar030
added
the
CI: ready for build
This was referenced Jun 8, 2020
bergzand
reviewed
Jun 9, 2020
bergzand
reviewed
Jun 9, 2020
bergzand
approved these changes
Jun 9, 2020
it is not used anywhere... |
I'm a bit hesistant with merging what is effectively dead code, but I don't really see the need to add a separate test for this. Does it make sense to add this as a default module to one of the tests, maybe just the unittests? |
OK, it'll increase RAM usage like if adding another idle thread, let's see if that's ok. |
kaspar030
requested review from
aabadie,
fjmolinas,
leandrolanzieri,
MichelRottleuthner and
smlng
as code owners
kaspar030
added
CI: ready for build
I added it to tests/test_utils, seems most fitting. |
This commit adds a module that just creates a thread that does nothing, at boot time, in auto_init().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
While looking at # #14181, I needed a quick way to add a thread. So this dummy thread module was born. If used, the module will start a dummy thread that only sleeps, in auto_init().
Use like this, to trick tests that assume a constant number of threads:
USEMODULE+=dummy_thread make -Ctests/rmutex flash test.This module is not used otherwise.
Testing procedure
Issues/PRs references