Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML21 SPI broken #6686

Closed
dylad opened this issue Mar 2, 2017 · 2 comments
Closed

SAML21 SPI broken #6686

dylad opened this issue Mar 2, 2017 · 2 comments

Comments

@dylad
Copy link
Member

dylad commented Mar 2, 2017

Hello,
I was doing some tests for #6645 with my saml21-xplained board but I'm facing a SPI issue.
It appears SPI for SAML21 is broken. I cannot leave spi_acquire function.
I also tried with tests/periph_spi, shell is blocked in a loop and SPI is not initialized.
I will try to investigate further and come up with a PR to fix it.
@dylad dylad mentioned this issue Mar 2, 2017
Merged
@dylad
Copy link
Member Author

dylad commented Mar 2, 2017

I figured out the problem.
SERCOM ID calculation located in cpu/sam0_common/include/periph_cpu_common.h is wrong for SAML family.
SERCOM0 is located at 0x42000800 for SAMD family and SERCOM0 is at 0x42000000UL for SAML family.
As this calculation is address related. It is obviously wrong for SAML.
#6687 fixes the problem.

@dylad dylad mentioned this issue Mar 21, 2017
Closed
23 tasks
@aabadie
Copy link
Contributor

aabadie commented Mar 21, 2017

As you referenced this issue in #6437. I think we can safely close this one.

@aabadie aabadie closed this as completed Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aabadie @dylad