Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyse_FadingMeasurement(): results only in NAs if no irradiation steps available #588

Closed
mcol opened this issue Feb 28, 2025 · 0 comments · Fixed by #590
Closed

analyse_FadingMeasurement(): results only in NAs if no irradiation steps available #588

mcol opened this issue Feb 28, 2025 · 0 comments · Fixed by #590
Milestone

Comments

@mcol
Copy link
Contributor

mcol commented Feb 28, 2025

Calling analyse_FadingMeasurement() on an XSYG file from which the irradiation steps have been removed produces this output:

[analyse_FadingMeasurement()]

 n.MC:	100
 tc:	1e-06 s
---------------------------------------------------
T_0.5 interpolated:	NA
T_0.5 predicted:	1e-06
g-value:		NA ± NA (%/decade)
g-value (norm. 2 days):	NA ± NA (%/decade)
---------------------------------------------------
rho':			NaN ± NA
log10(rho'):		NaN ± NA
---------------------------------------------------

We should instead check if all irradiation times are negative (which happens if no irradiation steps can be found), and if so return an helpful message, the current behaviour is very puzzling for any user.

@mcol mcol added this to the v1.1.0 milestone Feb 28, 2025
@mcol mcol changed the title analyse_FadingMeasurement(): results only in NAs if analyse_FadingMeasurement(): results only in NAs if no irradiation steps available Feb 28, 2025
@mcol mcol closed this as completed in #590 Feb 28, 2025
@mcol mcol modified the milestones: v1.1.0, v1.0.1 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant