Merge pull request #205 from sumitwebkul/gli-483

Prevent deleting profile which is used by at least one employee

Author: rohit053

classes/Profile.php

@@ -94,12 +94,17 @@ public function add($autodate = true, $null_values = false)
 
     public function delete()
     {
-        if (parent::delete()) {
-            return (
-                Db::getInstance()->execute('DELETE FROM `'._DB_PREFIX_.'access` WHERE `id_profile` = '.(int)$this->id)
-                && Db::getInstance()->execute('DELETE FROM `'._DB_PREFIX_.'module_access` WHERE `id_profile` = '.(int)$this->id)
-            );
+        // check if any employee exists of this deleting profile before delete
+        $profileEmployees = Employee::getEmployeesByProfile($this->id);
+        if (empty($profileEmployees)) {
+            if (parent::delete()) {
+                return (
+                    Db::getInstance()->execute('DELETE FROM `'._DB_PREFIX_.'access` WHERE `id_profile` = '.(int)$this->id)
+                    && Db::getInstance()->execute('DELETE FROM `'._DB_PREFIX_.'module_access` WHERE `id_profile` = '.(int)$this->id)
+                );
+            }
         }
+
         return false;
     }
 

controllers/admin/AdminProfilesController.php

@@ -115,4 +115,40 @@ public function initPageHeaderToolbar()
 
         parent::initPageHeaderToolbar();
     }
+
+    public function processDelete()
+    {
+        if (Validate::isLoadedObject($object = $this->loadObject())) {
+            // check if any employee exists of this deleting profile before delete
+            $profileEmployees = Employee::getEmployeesByProfile($object->id);
+            if (empty($profileEmployees)) {
+                return parent::processDelete();
+            } else {
+                $this->errors[] = $this->l('Failed to delete profile, because it is assigned to at least one employee.');
+            }
+        } else {
+            $this->errors[] = $this->l('An error occurred while deleting the profile.').' '.$this->l('(cannot load object)');
+        }
+
+        return false;
+    }
+
+    protected function processBulkDelete()
+    {
+        if (is_array($this->boxes) && !empty($this->boxes)) {
+            foreach ($this->boxes as $idProfile) {
+                // check if any employee exists of this deleting profile before delete
+                $profileEmployees = Employee::getEmployeesByProfile($idProfile);
+                if (!empty($profileEmployees)) {
+                    $this->errors[] = $this->l('Failed to delete profile with id').' - #'.$idProfile.' '.$this->l('because it is assigned to at least one employee. Please remove it from selection.');
+                }
+            }
+        }
+
+        if (empty($this->errors)) {
+            return parent::processBulkDelete();
+        }
+
+        return false;
+    }
 }