-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump PyO3 and rust-numpy to latest release #8612
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Looks like the conversion behavior changed in pyo3 0.17.0:
looking at the migration guide I expect this is caused by the addition of the |
PyO3 and rust-numpy just released version 0.17.0 respectively (and both are linked). This commit bumps the version used of both libraries to the latest release. For the changelogs see: https://github.com/PyO3/pyo3/releases/tag/v0.17.0 and https://github.com/PyO3/rust-numpy/releases/tag/v0.17.0
I've marked this as for 0.23.0 although I don't think there is actually a blocker for including it as part of 0.22.0. However, since the 0.22.0.rc1 is pending I say we merge this after |
Pull Request Test Coverage Report for Build 3274503710
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Bump PyO3 and rust-numpy to latest release PyO3 and rust-numpy just released version 0.17.0 respectively (and both are linked). This commit bumps the version used of both libraries to the latest release. For the changelogs see: https://github.com/PyO3/pyo3/releases/tag/v0.17.0 and https://github.com/PyO3/rust-numpy/releases/tag/v0.17.0 * Update Cargo.toml (cherry picked from commit 9674afd)
* Bump PyO3 and rust-numpy to latest release PyO3 and rust-numpy just released version 0.17.0 respectively (and both are linked). This commit bumps the version used of both libraries to the latest release. For the changelogs see: https://github.com/PyO3/pyo3/releases/tag/v0.17.0 and https://github.com/PyO3/rust-numpy/releases/tag/v0.17.0 * Update Cargo.toml (cherry picked from commit 9674afd) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Summary
PyO3 and rust-numpy just released version 0.17.0 respectively (and both
are linked). This commit bumps the version used of both libraries to the
latest release. For the changelogs see:
Details and comments
https://github.com/PyO3/pyo3/releases/tag/v0.17.0
and
https://github.com/PyO3/rust-numpy/releases/tag/v0.17.0