-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement frequency changes for pulse #3467
Comments
I think this is an excellent idea! Only recommendation I might have is to call this Are you planning on implementing @eggerdj? |
@taalexander Yes I'll implement this. Please assign me.
|
Yes, I can see that being the case. One option would be accept both types into the command in that case. Any thoughts @ajavadia on instruction operand type overloading? I know this is how LLVM does it. |
I guess accepting both types is an option. I worry that might make Pulse a little confusing for the end user? |
I agree it could, it would help if there was a formal language definition associated with pulse, eg., The equivalent of QASM in which typing in explicit. |
The WIP PR outlines what this would look like. Changing the name of the command is easy. Let me know if I forgot anything here. |
|
Thinking about this a bit more I am now comfortable with |
Yes, I agree with this. Frequency should only reference the LO of a given drive channel. |
What is the expected enhancement?
PulseChannel
s create the control fieldsRe[exp(i 2pi j dt f + phi)d_j]
. There should be aCommand
to change the frequencyf
of thePulseChannel
.This instruction will be implemented by
class SetChannelFrequency(Command)
. It will haveself._frequency
,scf
,The text was updated successfully, but these errors were encountered: