Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickLook crashes after Windows 10 20H2 upgrade #948

Open
eric3272 opened this issue Jul 1, 2021 · 19 comments
Open

QuickLook crashes after Windows 10 20H2 upgrade #948

eric3272 opened this issue Jul 1, 2021 · 19 comments

Comments

@eric3272
Copy link

eric3272 commented Jul 1, 2021

Ever since the 20H2 upgrade, QuickLook crashes every single time I touch the space bar. I installed it from Windows Store, version 3.6.11. Also tried installing it using the msi file, still seeing exactly the same issue. I'm not 100% sure if this is related to the Windows upgrade, but could someone please let me know what I can do to have it fixed?

Edit:

Describe the bug
The crashes start after getting the Windows 10 update KB5003537 on Windows 10 20H2 and trying to preview a large JSON file(over 25MB), then QuickLook becomes unresponsive and has to be force quit. After the force quit, QuickLook will crash immediately every time no matter what file type I want to preview.

To Reproduce
Steps to reproduce the behavior:

Get the Windows 10 update KB5003537 on Windows 10 20H2
Preview a large JSON file (over 25MB) and QuickLook becomes unresponsive
Force quit QuickLook when Windows 10 prompts
Reopen QuickLook and try to preview any file, QuickLook will crash.
Expected behavior
QuickLook will keep working as normal.

Desktop (please complete the following information):

OS Version: Windows 10 Pro 20H2, OS build 19042.1081
QuickLook Version: 3.6.11 both from MS store and the msi installation package

Screenshots and Exception Log
image

@eric3272
Copy link
Author

eric3272 commented Jul 1, 2021

After checking the Event Viewer logs, I found that the problem might have been caused by a windows 10 update (KB5003537), uninstalled the update and QuickLook is working again.

Attached below is the log content

Faulting application name: QuickLook.exe, version: 3.6.11.0, time stamp: 0x60451623
Faulting module name: clr.dll, version: 4.8.4390.0, time stamp: 0x609c45bd
Exception code: 0xc0000409
Fault offset: 0x0000000000332a8c
Faulting process id: 0x1a8c
Faulting application start time: 0x01d76e8f707b4a35
Faulting application path: C:\Program Files\WindowsApps\21090PaddyXu.QuickLook_3.6.11.0_neutral__egxr34yet59cg\Package\QuickLook.exe
Faulting module path: C:\Windows\Microsoft.NET\Framework64\v4.0.30319\clr.dll
Report Id: 10b67ff3-8e3c-48d1-99f4-8d681ac5050e
Faulting package full name: 21090PaddyXu.QuickLook_3.6.11.0_neutral__egxr34yet59cg
Faulting package-relative application ID: Main

@eric3272
Copy link
Author

eric3272 commented Jul 2, 2021

An update on this issue.

I reinstalled the Windows 10 update KB5003537 once QuickLook started working again after I had uninstalled it, then QuickLook was working fine with the Windows 10 update installed until I tried to preview a large JSON(over 20MB) and QuickLook became unresponsive, so I had to force quit it. And this is when it started to crash again every time I try to use it, had to uninstall the windows 10 update again to have QuickLook back. I'm seeing the exact same Event Viewer logs for this error.

@xupefei
Copy link
Member

xupefei commented Jul 5, 2021

Could you modify the issue according to the template? Only so I know what exactly is the problem and how to reproduce it.

@eric3272
Copy link
Author

eric3272 commented Jul 5, 2021

Describe the bug
The crashes start after getting the Windows 10 update KB5003537 on Windows 10 20H2 and trying to preview a large JSON file(over 25MB), then QuickLook becomes unresponsive and has to be force quit. After the force quit, QuickLook will crash immediately every time no matter what file type I want to preview.

To Reproduce
Steps to reproduce the behavior:

  1. Get the Windows 10 update KB5003537 on Windows 10 20H2
  2. Preview a large JSON file (over 25MB) and QuickLook becomes unresponsive
  3. Force quit QuickLook when Windows 10 prompts
  4. Reopen QuickLook and try to preview any file, QuickLook will crash.

Expected behavior
QuickLook will keep working as normal.

Desktop (please complete the following information):

  • OS Version: Windows 10 Pro 20H2, OS build 19042.1081
  • QuickLook Version: 3.6.11 both from MS store and the msi installation package

Screenshots and Exception Log
image

@xupefei
Copy link
Member

xupefei commented Jul 6, 2021

Mind to share me the 25MB JSON file?

@eric3272
Copy link
Author

eric3272 commented Jul 6, 2021

Yes, I have thousands of them and I don't remember which one it was that I tried to preview that caused the crashes, but I believe all of them should do as long as it causes QuickLook to freeze due to the relatively large file size. I'm attaching one of them and hope it'll help.

All-high.zip

@eric3272
Copy link
Author

eric3272 commented Jul 6, 2021

Not sure if this will help, but I have Atom as the default app to open JSON files.

@xupefei xupefei closed this as completed in 971285f Jul 6, 2021
@xupefei
Copy link
Member

xupefei commented Jul 6, 2021

I see a large amount of time spent in Regex matching when trying to apply syntax highlight to the JSON file.
Can you try https://ci.appveyor.com/project/xupefei/quicklook/builds/39890560/artifacts https://ci.appveyor.com/project/xupefei/quicklook/builds/39890704/artifacts and see if the issue has been fixed?

@xupefei xupefei reopened this Jul 6, 2021
@eric3272
Copy link
Author

eric3272 commented Jul 6, 2021

Hi Paddy, I'm still experiencing the same issue with the new MSI, attached is the new Event Viewer log screenshot.

I reinstalled the update KB5003537 and was paying attention to not open large JSON with QuickLook, so it was working fine. But after uninstalling the MS store version and unzipped the folder to the QuickLook folder, then tried to open a large JSON, this time it skipped the steps of QuickLook becoming unresponsive and having to be force quit, it's now crashing every time I try to preview any file.

image

@xupefei
Copy link
Member

xupefei commented Jul 6, 2021

That's weird. Could you reboot and try again?
Also, do you have a crash log at any of these locations: https://github.com/QL-Win/QuickLook/wiki/Differences-Between-Distributions#user-data-location?

@eric3272
Copy link
Author

eric3272 commented Jul 6, 2021

Hey Paddy, thanks for the follow-up! I have to run, will update you when I'm back or tomorrow!

@eric3272
Copy link
Author

eric3272 commented Jul 8, 2021

Hi, I installed 3.6.11-21 with the msi package and it's now working fine, I will update you once anything comes up again.

I didn't find logs from any of the listed locations in the link.

Also, I realized that the whole issue was probably not caused by the Windows 10 update KB5003537, because the MS store version QuickLook started to work again for a few days after I uninstalled the update, then I started to have the exact same issue with QuickLook (MS store 3.6.11) crashing every time I used it, and the Event Viewer log states the same issue with the clr.dll file.

I'll come back if anything goes wrong again. Thank you very much for the help!

@xupefei
Copy link
Member

xupefei commented Jul 8, 2021

Wonderful. Please reopen this ticket if you see the same issue again.

@xupefei xupefei closed this as completed Jul 8, 2021
@eric3272
Copy link
Author

Hey Paddy,

I'm sorry that the same issue is happening again even though I'm currently using the 3.6.11-21 version, this time it seems to have started with another Windows 10 update on July 11, I uninstalled the update and QuickLook is now working again. Event Viewer logs suggest it's the same clr.dll file that's the faulting module. I checked the listed locations for crash logs, but didn't find anything. However, I do have a few crash dump files and I'm attaching the latest one and hope that would help. Let me know if you would need any other information from me.

QuickLook.exe.18244.zip

@xupefei
Copy link
Member

xupefei commented Jul 12, 2021

How about deleting the TextViewer plugin?

@eric3272
Copy link
Author

Thanks for the response Paddy, I'll try as soon as I get the chance and let you know what happens.

@eric3272
Copy link
Author

Hi Paddy,

I tried deleting the TextViewer plugin, but unfortunately, I'm still having the exact same issue. I found another Windows Error Report and the screenshot of it is attached. I don't know if the "Report.wer" file would be of any value to you, but if it's necessary to you, it's attached in the zip file.

Also, the issue may not be related to Windows updates because I paused Windows updates since the last time I experienced this issue. But QuickLook 3.6.11-21 all of a sudden started to crash again today even without any Windows updates installed. Please let me know how I can help and I'll share anything with you.

Report.zip
image

@eric3272
Copy link
Author

Just an update, I restarted my computer after deleting the TextViewer plugin, and QuickLook is now working for most other file types, when I put the TextViewer plugin back in the QuickLook.Plugin folder, it started to crash again, so I guess it might be related to the TextViewer plugin?

@Roundlay
Copy link

Just an update, I restarted my computer after deleting the TextViewer plugin, and QuickLook is now working for most other file types, when I put the TextViewer plugin back in the QuickLook.Plugin folder, it started to crash again, so I guess it might be related to the TextViewer plugin?

This was really helpful to know. I was consistently encountering a hang and subsequent crash on my first attempt to run QuickLook, which would curiously resolve itself in subsequent runs. After I removed the TextViewer plugin, I noticed an immediate improvement. The preview times are remarkably faster and the previous issues seem to have disappeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants