Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The syntax highlighting of all source code files not work on the newest v3.7.2 #1210

Open
supersu097 opened this issue Nov 9, 2022 · 6 comments

Comments

@supersu097
Copy link

For all's convenience, please use English to fill this issue.

Please search within existing issues before the submission. Has this issue already been reported?
nope
Describe the bug
The syntax highlighting of all source code files disappear

To Reproduce
as above

Expected behavior
syntax highlighting should work as before

Desktop (please complete the following information):

  • OS Version: windows 10 20H2
  • QuickLook Version: v3.7.2
  • Microsoft Edge WebView2 Runtime 107.0.1418.35

Screenshots and Exception Log
If applicable, add screenshots and logs to help explain your problem. The log file is located in one of several locations.

@supersu097 supersu097 changed the title The syntax highlighting of all source code files not work on the newest v3.7.2 on the windows 10 20H2 The syntax highlighting of all source code files not work on the newest v3.7.2 Nov 9, 2022
@rabelux
Copy link
Member

rabelux commented Nov 9, 2022

Are you using dark mode?

@supersu097
Copy link
Author

Are you using dark mode?

nope, I'm not using the dark mode, now i rollback to v3.7.1 and everything works fine, but i really really hope to use the newest version, so sad.

@mooflu
Copy link
Contributor

mooflu commented Nov 11, 2022

Looks like the syntax files aren't included in the build anymore.
They were moved to a subfolder but are now tagged to not be copied:

  <Content Include="Syntax\**">
      <CopyToOutputDirectory>None</CopyToOutputDirectory>
  </Content>

660dc88#diff-fd4260eb87ae71145d63d99b37eb3b5433e1b6385f6c114f42a8b30f1cf61186R92

When I add them back, it fails to load the "HTML.xshd" syntax file which references the javascript syntax definition which hasn't loaded yet. Probably best to just remove the HTML syntax file, since html viewer plugin would be used for html files anyway.

@xupefei
Copy link
Member

xupefei commented Nov 14, 2022

Hmm that is strange. Let me check what's happening.

@supersu097
Copy link
Author

Hi all, how is it going here? I'm looking forward to seeing the good news.

@Solitario119
Copy link

I have the same problem too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants