Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option in settings to pass command line flags to DCMTK tools #4

Closed
fedorov opened this issue Feb 10, 2017 · 5 comments
Closed

Add option in settings to pass command line flags to DCMTK tools #4

fedorov opened this issue Feb 10, 2017 · 5 comments

Comments

@fedorov
Copy link
Member

fedorov commented Feb 10, 2017

suggested by @jriesmeier

@jriesmeier
Copy link
Member

jriesmeier commented Feb 12, 2017

Thanks for your quick implementation! It works... but for a single option (e.g. "-M") only. If I specify multiple options (e.g. "-M -L"), the output window is empty. Could be a quoting issue, i.e. a problem with " around the options.

@fedorov
Copy link
Member Author

fedorov commented Feb 13, 2017

Thanks for letting me know! This should be fixed in 0.2.10 by this commit: 25d822e. The problem was that each flag should be passed as a separate item in the arguments array.

I also added clarification to the config options that no quotes around the command line flags should be used.

@jriesmeier
Copy link
Member

I can confirm that it works now with more than a single option, e.g. with "-M -L" (see above). This is at least true as long as no quotation marks are used (e.g. as required for option values that contain spaces or other special characters), but as you've documented: "no quotes!" ;-)

Also thank you for changing the order of the input fields. This is something that I also observed for the previous version/release (but forgot to mention).

@fedorov
Copy link
Member Author

fedorov commented Feb 13, 2017

as long as no quotation marks are used (e.g. as required for option values that contain spaces or other special characters)

If you have some arguments that need to be passed to a certain flag, I should be able to make it work by improving the robustness of the flags parsing. Right now I just split by space the text passed by the user. If you believe it is important to be able to pass flag options and they may contain spaces (i.e., those flags and options are really useful in this context), can you please add example to this issue?

Also thank you for changing the order of the input fields

I noticed it earlier too, and was annoyed about it, but could not quickly find documentation how to specify the order (default is sort alphabetically). This time I was more successful! :)

@jriesmeier
Copy link
Member

I think for dcmdump and dsrdump there is no good example why quotation marks (for escaping spaces or other special characters) would be needed. So, it probably makes no sense to invest this extra time. It might be different for other DCMTK tools...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants