Make CLI able to handle Unicode characters output on Windows console #968
+110
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bact
commented
Nov 2, 2024
•
bact
commented
- Split cli tests to test_cli.py and testx_cli.py, test_cli will have only tests that do not require additional dependencies
- Use safe_print (Add pythainlp.tools.safe_print to handle UnicodeEncodeError on console #969) so it plays nicely with UnicodeEncodeError on Windows console
- Also set utf-8 in cli code and in GitHub workflow, so it can print Unicode characters
- Errors related to Unicode in command line tests are now fixed
|
bact
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.