Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.12.2 #170

Closed
wants to merge 1 commit into from
Closed

Release v0.12.2 #170

wants to merge 1 commit into from

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented Dec 22, 2020

Unfortunately releasing PyO3 0.13 has broken rust-numpy 0.12 versions because the Cargo.toml is too flexible.

I think we should release rust-numpy version 0.12.2 with a restricted version to fix the issue for users who need to continue with rust-numpy 0.12 for now.

Also #163 contains all the fixes needed for rust-numpy to work on PyO3 0.13, for an eventual rust-numpy 0.13.

Closes #169

@davidhewitt
Copy link
Member Author

@kngwyu I don't have permissions to release this branch. I thought it would be helpful for you if I pushed it.

@kngwyu
Copy link
Member

kngwyu commented Dec 23, 2020

What is the base branch of this?

@davidhewitt
Copy link
Member Author

It's the v0.12.1 tag with one extra commit.

You probably don't want to merge this as-is into master. More I pushed this branch so that it could be made into a patch release.

@kngwyu
Copy link
Member

kngwyu commented Dec 23, 2020

Thanks, but I usually use release-0.* branches for patch releases and will manually cherry-pick your commit to release-0.12.

@kngwyu kngwyu closed this Dec 23, 2020
@kngwyu
Copy link
Member

kngwyu commented Dec 23, 2020

Done: https://github.com/PyO3/rust-numpy/releases/tag/v0.12.2

@messense messense deleted the release-0.12.2 branch July 11, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile error for latest releases of pyo3 and numpy
2 participants