Python3 bin #596
Merged
Python3 bin #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expobrain
force-pushed
the
python3_bin
branch
from
237874a to
7ce47f3
Compare
kngwyu
approved these changes
Sep 7, 2019
build.rs
Outdated
| @@ -425,22 +426,22 @@ fn find_interpreter_and_get_config() -> Result<(InterpreterConfig, HashMap<Strin | |||
| }; | |||
|
|
|||
| // check default python | |||
| let interpreter_path = "python"; | |||
| // let interpreter_path = "python3"; | |||
There was a problem hiding this comment.
Could you please remove this line?
|
It's a really nice refactoring 👍 , thank you! |
expobrain
force-pushed
the
python3_bin
branch
from
7ce47f3 to
a883bdb
Compare
|
@kngwyu yes, it solves exactly that issue |
expobrain
force-pushed
the
python3_bin
branch
from
a883bdb to
bd426d4
Compare
|
Ah, sorry, now I noticed the Windows CI fails because of this fix. |
|
Interesting, I'm wondering if make sense to check in order for both |
kngwyu
reviewed
Sep 8, 2019
build.rs
Outdated
|
|
||
| lazy_static! { | ||
| static ref PYTHON_INTERPRETER: &'static str = { | ||
| vec!["python3", "python"] |
There was a problem hiding this comment.
Suggested change
| vec!["python3", "python"] | |
| ["python3", "python"] | |
| .iter() | |
| .find_map(|bin| Command::new(bin).spawn().ok().map(|_| bin)) | |
| .expect("Python 3.x interpreter not found") |
|
Thanks! |
expobrain
force-pushed
the
python3_bin
branch
from
ed5cd0a to
fe9575a
Compare
|
Thank you! |
|
Thank you for the fix 👍. Just saw that the issue was closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly use the
python3binary instead of lainpythonto target Python 3.x even on systems where Python 2.x is not installed