pyproto: don't use inventory for methods #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
no-pyproto-inventory
branch
from
4543ac5 to
aa2855b
Compare
kngwyu
approved these changes
Feb 26, 2021
| @@ -210,7 +210,7 @@ pub fn add_fn_to_module( | |||
| pyo3::types::PyCFunction::internal_new( | |||
| name, | |||
| doc, | |||
| pyo3::class::PyMethodType::PyCFunctionWithKeywords(#wrapper_ident), | |||
| unsafe { std::mem::transmute(#wrapper_ident as *const std::os::raw::c_void) }, | |||
There was a problem hiding this comment.
This is actually a function-pointer-to-function-pointer cast (I changed the arguments to PyCFunction::internal_new).
Actually I think I can get rid of this by refactoring PyCFunction::internal_new a bit more. It will have a slight user-facing change (but a good one imo) so I'll do it in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step in making inventory optional, by changing
#[pyproto]methods which use inventory to also use dtolnay specialization.It works very similarly to #1328.
From a very basic benchmark, this doesn't appear to change performance of type object initialization at all. (Perf doesn't matter very much here anyway, as this is only something that runs once on library startup.)
The next (and final) PR in this series will make it so that
inventoryis optional. Without inventory, you will only be allowed one#[pymethods]for each#[pyclass]. However you will get faster compile times and support on platforms where inventory isn't available :)