fix: Add parameter to decide wheter remove resource in aggregation function #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mstechly
approved these changes
Aug 16, 2024
| @@ -37,6 +39,10 @@ def add_aggregated_resources(routine: Routine, aggregation_dict: Dict[str, Dict[ | |||
| "arbitrary_z": {"T_gates": "3*log2(1/epsilon) + O(log(log(1/epsilon)))"}, | |||
| ... | |||
| } | |||
| remove_decomposed : Whether to remove the decomposed resources from the routine. | |||
There was a problem hiding this comment.
[nitpick] There's unnecessary space before :
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves issue #106 by adding the
remove_decomposedparameter to theadd_aggregated_resourcesfunction.Context:
In certain use cases, it is necessary to preserve the original resources after they have been aggregated. Previously, the
add_aggregated_resourcesfunction automatically removed the original resources after aggregation.Implemented Solution:
remove_decomposedhas been added to theadd_aggregated_resourcesfunction.remove_original=True(default): The original resource is removed after aggregation.remove_original=False: The original resource is retained, and its type is marked as "other" to distinguish it from other resources (a straightforward approach; however, there may be more optimized solutions.)TrueandFalse).Dependencies:
No new dependencies were added in this PR.
Please verify that you have completed the following steps