Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Fix ] Global support on WAMP #61

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[ Fix ] Global support on WAMP #61

wants to merge 3 commits into from

Conversation

ProjektGopher
Copy link
Owner

Resolves #58

It seems like base_path() and getGlobalComposerHome() don't quite match up on WAMP. Possibly some sort of symlinking. But by checking explicitly for isRunningLocally instead of isRunningGlobally and having global be the default fallback, I think this'll fix it.

@ProjektGopher
Copy link
Owner Author

May have to update Whisky::isDogfooding() to detect running phar from builds/whisky as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Can't run global whisky install on WAMP
1 participant
@ProjektGopher