Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows Support] Install Command - chmod not recognized #12

Closed
ProjektGopher opened this issue Jun 6, 2023 · 2 comments · Fixed by #36
Closed

[Windows Support] Install Command - chmod not recognized #12

ProjektGopher opened this issue Jun 6, 2023 · 2 comments · Fixed by #36

Comments

@ProjektGopher
Copy link
Owner

ProjektGopher commented Jun 6, 2023 •
edited
Loading

  • whisky install
Creating whisky.json in project root...
'chmod' is not recognized as an internal or external command,
operable program or batch file.
'chmod' is not recognized as an internal or external command,
operable program or batch file.
Git hooks installed successfully.
@ProjektGopher ProjektGopher changed the title Windows Support [Windows Support] Install Command - chmod not recognized Jun 7, 2023
@gpibarra
Copy link
Contributor

this can be easily done using the new Whiskey::isWindows() method.
It will depend if you use that function or the Platform one app/Platform.php
However, this warning does not prevent it from working on windows.

@ProjektGopher
Copy link
Owner Author

When I'm able to finish my refactoring I'll be using the Platform classes method. This should be an easy win

@ProjektGopher ProjektGopher mentioned this issue Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ Fix ] Skip chmod if on windows during install ProjektGopher/whisky
2 participants
@ProjektGopher @gpibarra