Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename name_table class and name_id property #4709

Open
4 tasks
karenzshea opened this issue Nov 28, 2017 · 2 comments
Open
4 tasks

Rename name_table class and name_id property #4709

karenzshea opened this issue Nov 28, 2017 · 2 comments

Comments

@karenzshea
Copy link
Contributor

karenzshea commented Nov 28, 2017

Why rename

At this point the NameTable class stores a lot more than just name strings; it holds also refs, exit numbers, destinations, and pronunciations. Because it's then semantically confusing to do data.name_id != EMPTY_NAMEID checks (this checks that a name id's entry in the name table is 0, rather than checks that a way has no name data) (see #4642) name table and all associated classes, members, files (possibly) should be renamed.

To rename

  • util::NameTable -> util::PreDatafacadeStringViewer
  • NodeBasedEdgeAnnotation::NameID -> NodeBasedEdgeAnnotation::StringViewID
  • name_id -> string_view_id
  • EMPTY_NAMEID -> EMPTY_STRINGVIEWID

cc @daniel-j-h

@DaGuich
Copy link
Contributor

DaGuich commented Jul 20, 2018

Is this task still relevant?

@danpat
Copy link
Member

danpat commented Jul 20, 2018

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants