Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NSIS 3.03, bug-fixes #1285

Closed
wants to merge 7 commits into from
Closed

Add support for NSIS 3.03, bug-fixes #1285

wants to merge 7 commits into from

Conversation

idleberg
Copy link
Contributor

@idleberg idleberg commented Feb 9, 2018

No description provided.

@Golmote
Copy link
Contributor

Golmote commented Feb 9, 2018

Hi @idleberg! Thanks for contributing again!
Could you please not remove the ?: parts? They were intended, as all those captures are not required.
Only the two occurrences of (^\s*) are required to be captured for the lookbehind feature to work.

@Golmote
Copy link
Contributor

Golmote commented Feb 9, 2018

You misunderstood me. The ?: should not be removed.

@idleberg
Copy link
Contributor Author

idleberg commented Feb 9, 2018

I don't see which commit (prior to b490d6a) removed any ?:

@Golmote
Copy link
Contributor

Golmote commented Feb 9, 2018

Hm... The global diff on the PR tells differently.
Are you working from an up-to-date branch? The ?: are in the current NSIS file, but are not in your first commit (a98c16b).

@idleberg
Copy link
Contributor Author

idleberg commented Feb 9, 2018

You were right, my fork was not up-to-date. Closing in favour of #1288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants