Skip to content

Commit 8fe3600

Browse files
committed
Return False in 2x regression tests when analyze() detects issue
Closes #174
1 parent 11f0c11 commit 8fe3600

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

src/task_list/task_list.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ class TimeIntegratorTaskList : public TaskList {
155155

156156

157157
//----------------------------------------------------------------------------------------
158-
// 64-bit integers with "1" in different bit positions used to ID each hydro task.
158+
// 64-bit integers with "1" in different bit positions used to ID each hydro task.
159159

160160
namespace HydroIntegratorTaskNames {
161161
const uint64_t NONE=0;

tst/regression/scripts/tests/curvilinear/blast_sph.py

+1
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,6 @@ def analyze():
3333
# check blast is spherical
3434
if data[0][3] > 1.0:
3535
print("Distortion of blast wave in spherical coords too large", data[0][3])
36+
return False
3637

3738
return True

tst/regression/scripts/tests/symmetry/hydro_linwave_aligned.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ def analyze():
9898
# (Differences in d_max can exceed 2e-15, but other differences are 2e-16 at most)
9999
atol = 5e-15
100100
rtol = 1e-8
101+
102+
# Useful optional diagnostics for determining if differences are meaningful in FP:
101103
# print(np.allclose(results_1D, results_2D, atol=atol, rtol=rtol))
102104
# print("numpy tolerance = {}".format(atol + 1e-10*abs(results_2D)))
103105
# print(np.allclose(results_2D, results_3D, atol=atol, rtol=rtol))
@@ -113,6 +115,6 @@ def analyze():
113115
print(results_2D)
114116
print(results_3D)
115117
print("Exhibit differences that are not close to round-off")
116-
# return False
118+
return False
117119

118120
return True

0 commit comments

Comments
 (0)