Skip to content

Added Images to README.md #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ShiroTohu
Copy link
Collaborator

Added images using script.

Hopefully all content is correct and everything is as it should be. The images are links to the from steam's content distribution network. I doubt that the images will change even if the content on the store page is changed because I imagine that new images would be assigned a new unique id.

I was a bit hesitant to add images because it took a lot of space. But it definitely allows readers to glance at the game and understand the gist of it in an instant. It also makes the list more colourful.

closes #34

Added images using script.
Copy link
Collaborator

@rammba rammba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ShiroTohu thanks for the amazing improvement. You really created more descriptive list 🚀
I've added some comments regarding additional changes (except images). For some of those I'm not that confident to approve without @Poussinou.
Better solution can be to just add images for the existing games, and to tackle other improvements in separate PRs.

@@ -719,10 +1116,16 @@ Solve puzzles by designing an AI for a team of selfless heroes. Test your algori
<!-- HyperLinks -->
[Game on Steam](https://store.steampowered.com/app/915720/Session_Seven/) | [Source Code](https://github.com/advdotnet/Session-Seven) | [Website](https://www.sessionseven.com)

Session Seven is a free point & click adventure game in which you play as Ryan, an estranged father and husband who has just awoken, beaten, bruised, and alone in a locked cellar.
Session Seven is a free point &amp; click adventure game in which you play as Ryan, an estranged father and husband who has just awoken, beaten, bruised, and alone in a locked cellar.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary?

@@ -968,13 +1498,18 @@ An evolution simulation game. Take control of your species in the environment an
![Static Badge](https://img.shields.io/badge/SteamOS%2FLinux-%23272932?style=for-the-badge&logo=steam)

<!-- HyperLinks -->
[Mod on Steam](https://store.steampowered.com/app/1281930/tModLoader/) | [Source Code](https://github.com/tModLoader/tModLoader) | [Website](www.tmodloader.net/) | [Donate](https://www.patreon.com/tmodloader)
[Mod on Steam](https://store.steampowered.com/app/1281930/tModLoader/) | [Source Code](https://github.com/tModLoader/tModLoader) | [Website](https://www.patreon.com/tmodloader) | [Donate](https://store.steampowered.com/app/105600/Terraria/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incorrect. Can you please revert this line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how in the world did this happen? haha


Dig, Fight, and Build your way through the world of player-created mods on Terraria with tModLoader - this DLC makes modding Terraria a reality!\
_Note: In order to use this mod, you need to own [Terraria](https://store.steampowered.com/app/105600/Terraria/) on the Steam. Terraria is not FLOSS, but proprietary software._
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was here intentionally. Please revert this change.


## Zero-K
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove Zero-K?

* ~~Platforms supported?~~
* Add license (and specifications for assets, most of the time they aren't floss)?
* Cost?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create issues for TODOs here if you think we should implement them.


<!--* ## Warzone 2100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are few games that are added to the list (uncommented), I would add those in separate PR if you agree.
All of them (Good Robot, Lugaru HD, Warzone 2100), looks legit to be on this list, but maybe @Poussinou knows why those are commented?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#28 is the reason why Warzone 2100 is unavailable. As for the others there are no pull requests or issues that I could find at a glance. There are also no commits I could find that specifically mention the other two games. But I imagine there is probably a good reason as to why these games are removed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would wait @Poussinou for those games since I don't know also.

@@ -877,8 +1359,14 @@ Teeworlds is a free online multiplayer game, available for all major operating s
<!-- HyperLinks -->
[Game on Steam](https://store.steampowered.com/app/972560/Termite/) | [Source Code](https://github.com/milgra/termite) | [License GPLv3](https://github.com/milgra/termite/blob/master/LICENSE) | [Donate](https://www.paypal.com/paypalme/milgra)

Termite is a psychedelic real-time action strategy experience. You are the leader of a termite hive with three objectives: collect food, produce ants and destroy alien colonies.
The ultimate real-time action strategy experience
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating description, platform list & game names. Is it a problem to fix that in separate commits or PRs? This one is "only" adding a pictures.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, that is probably something to mention in a separate commit.

@ShiroTohu
Copy link
Collaborator Author

Wow! I didn't realize there was that many problems with it.

The script I made scrapped relevant game information and images from the steam store page. I also gathered information from the latest commit of the list such as each games relevant links (such as donation links, website, etc.). All the errors showcased are from coding errors on my part.

I'll definitely make some revisions to it and fix the aforementioned errors. I'll also revert the descriptions back to what they were beforehand.

Appreciate you looking through the new list and highlighting these errors.

@rammba
Copy link
Collaborator

rammba commented Mar 12, 2025

@ShiroTohu I'm now interested what your script also can do 🚀
I would say, this PR can contain images and updated game names/descriptions. I think other changes can go to different PR. What do you think?

@ShiroTohu
Copy link
Collaborator Author

This PR does contain much more things than I stated. I might close this PR and reopen another one with just the images and then work from there.

@ShiroTohu ShiroTohu closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshots
2 participants