Remove strict deprecations about "any" types

Author: Pierstoval

build/index.js

@@ -30,12 +30,10 @@ var App = /** @class */ (function () {
         this.refreshRandomPattern();
     };
     App.prototype.refreshRandomPattern = function () {
-        // const handpan_notes = handpan_notes_input.value;
         var number_of_bars = Number(this.number_of_bars_input.value);
-        var rhythm = App.getRadioButtonValue(this.rhythm_inputs);
-        // handpan_notes_result_element.innerText = handpan_notes;
+        var rhythm = parseInt(App.getRadioButtonValue(this.rhythm_inputs), 10);
         this.number_of_bars_result_element.innerText = String(number_of_bars);
-        this.patterns_container.setAttribute('data-rhythm', rhythm);
+        this.patterns_container.setAttribute('data-rhythm', rhythm.toString());
         this.patterns_container.innerHTML = '';
         var number_of_notes = number_of_bars * rhythm;
         this._currentPattern = new Pattern(rhythm, this.handpan_tune);
@@ -48,13 +46,16 @@ var App = /** @class */ (function () {
         console.info('Pattern:', this._currentPattern);
     };
     App.getRadioButtonValue = function (radios_list) {
-        for (var _i = 0, radios_list_1 = radios_list; _i < radios_list_1.length; _i++) {
-            var item = radios_list_1[_i];
+        var value = '';
+        radios_list.forEach(function (item) {
+            if (!(item instanceof HTMLInputElement)) {
+                return;
+            }
             if (item.checked) {
-                return item.value;
+                value = item.value;
             }
-        }
-        return null;
+        });
+        return value;
     };
     return App;
 }());
@@ -64,7 +65,7 @@ var Hand;
     Hand[Hand["right"] = 1] = "right";
 })(Hand || (Hand = {}));
 var HandpanHit = /** @class */ (function () {
-    function HandpanHit(hit_type, hand, notes) {
+    function HandpanHit(hit_type, hand) {
         this.hit_type = hit_type;
         this.hand = hand;
     }
@@ -75,7 +76,7 @@ var HandpanHit = /** @class */ (function () {
         var random_boolean = Math.floor(Math.random() * 2);
         var hand = random_boolean ? Hand.left : Hand.right;
         var hit_type = HitType.getRandomHitType();
-        return new HandpanHit(hit_type, hand, []);
+        return new HandpanHit(hit_type, hand);
     };
     return HandpanHit;
 }());

src/App.ts

@@ -15,7 +15,7 @@ class App {
 
     private _running: boolean = false;
 
-    private _currentPattern: Pattern<HandpanHit>;
+    private _currentPattern: Pattern;
     private _patternRenderer: PatternRenderer;
 
     constructor(
@@ -65,19 +65,17 @@ class App {
     }
 
     refreshRandomPattern(): void {
-        // const handpan_notes = handpan_notes_input.value;
         const number_of_bars = Number(this.number_of_bars_input.value);
-        const rhythm = App.getRadioButtonValue(this.rhythm_inputs);
+        const rhythm = parseInt(App.getRadioButtonValue(this.rhythm_inputs), 10);
 
-        // handpan_notes_result_element.innerText = handpan_notes;
         this.number_of_bars_result_element.innerText = String(number_of_bars);
 
-        this.patterns_container.setAttribute('data-rhythm', rhythm);
+        this.patterns_container.setAttribute('data-rhythm', rhythm.toString());
         this.patterns_container.innerHTML = '';
 
         let number_of_notes = number_of_bars * rhythm;
 
-        this._currentPattern = new Pattern<HandpanHit>(rhythm, this.handpan_tune);
+        this._currentPattern = new Pattern(rhythm, this.handpan_tune);
 
         for (let i = 0; i < number_of_notes; i++) {
             // Choose a "hit" type randomly in the list
@@ -91,13 +89,19 @@ class App {
         console.info('Pattern:', this._currentPattern);
     }
 
-    private static getRadioButtonValue(radios_list) {
-        for (let item of radios_list) {
+    private static getRadioButtonValue(radios_list: NodeList): string {
+        let value = '';
+
+        radios_list.forEach(function (item: Node) {
+            if (!(item instanceof HTMLInputElement)) {
+                return;
+            }
+
             if (item.checked) {
-                return item.value;
+                value = item.value;
             }
-        }
+        });
 
-        return null;
+        return value;
     }
 }

src/HandpanHit.ts

@@ -3,19 +3,19 @@ class HandpanHit {
     public readonly hit_type: HitType;
     public readonly hand: Hand;
 
-    private constructor(hit_type: HitType, hand: Hand, notes) {
+    private constructor(hit_type: HitType, hand: Hand) {
         this.hit_type = hit_type;
         this.hand = hand;
     }
 
     /**
      * @param pattern to add logic instead of randomness when generating a pattern
      */
-    public static createRandomHit(pattern: Pattern<HandpanHit>): HandpanHit {
+    public static createRandomHit(pattern: Pattern): HandpanHit {
         let random_boolean = Math.floor(Math.random() * 2);
         let hand = random_boolean ? Hand.left : Hand.right;
         let hit_type = HitType.getRandomHitType();
 
-        return new HandpanHit(hit_type, hand, []);
+        return new HandpanHit(hit_type, hand);
     }
 }

src/Pattern.ts

@@ -1,4 +1,4 @@
-class Pattern<HandpanHit> {
+class Pattern {
     private readonly _hits: Array<HandpanHit> = [];
     private readonly _handpan_tune: HandpanTune;
 

src/PatternRenderer.ts

@@ -7,7 +7,7 @@ class PatternRenderer {
         this.container = container;
     }
 
-    public renderPattern(pattern: Pattern<HandpanHit>): void {
+    public renderPattern(pattern: Pattern): void {
         let number_of_notes = pattern.count;
 
         let i = 0;
@@ -34,7 +34,7 @@ class PatternRenderer {
         }
     }
 
-    private createPatternItem(pattern: Pattern<HandpanHit>, handpan_hit: HandpanHit): HTMLElement {
+    private createPatternItem(pattern: Pattern, handpan_hit: HandpanHit): HTMLElement {
         const pattern_item = document.createElement('div');
         pattern_item.className = 'pattern_item';
 

tsconfig.json

@@ -3,7 +3,7 @@
         "incremental": true,
         "target": "es5",
         "module": "none",
-        "noImplicitAny": false,
+        "noImplicitAny": true,
         "outFile": "./build/index.js",
         "strict": true
     },