feat: hide pit traps from enemies

Author: Picoseconds

src/items/items.ts

@@ -184,6 +184,10 @@ function getGameObjPlaceLimit(item: ItemType) {
   return items[item].group.limit || Infinity;
 }
 
+function shouldHideFromEnemy(item: ItemType) {
+  return !!items[item].hideFromEnemy;
+}
+
 export {
   PrimaryWeapons,
   SecondaryWeapons,
@@ -205,5 +209,6 @@ export {
   getStructureDamage,
   getGameObjHealth,
   getGameObjDamage,
-  getGameObjPlaceLimit
+  getGameObjPlaceLimit,
+  shouldHideFromEnemy
 };

src/moomoo/Game.ts

@@ -915,7 +915,6 @@ export default class Game {
               )
             )
           }
-
         }
         break;
       case PacketType.CLAN_ACC_JOIN:
@@ -929,6 +928,9 @@ export default class Game {
             player.clanName = tribe.name;
 
             this.state.joinClan(player, tribe);
+
+            // for pit traps to appear
+            this.sendGameObjects(player);
           }
         }
 

src/moomoo/Physics.ts

@@ -5,6 +5,9 @@ import { getWeaponAttackDetails, hasCollision, getGameObjDamage } from "../items
 import GameState from "./GameState";
 import { ItemType } from "../items/UpgradeItems";
 import { getHat } from "./Hats";
+import { PacketType } from "../packets/PacketType";
+import { Packet } from "../packets/Packet";
+import { PacketFactory } from "../packets/PacketFactory";
 
 function collideCircles(pos1: Vec2, r1: number, pos2: Vec2, r2: number) {
   return pos1.distance(pos2) <= r1 + r2;
@@ -33,14 +36,25 @@ function collidePlayerGameObject(player: Player, gameObj: GameObject) {
 
 function tryMovePlayer(player: Player, delta: number, xVel: number, yVel: number, state: GameState) {
   let inTrap = false;
+  let packetFactory = PacketFactory.getInstance();
 
   let newLocation = new Vec2(
     player.location.x,
     player.location.y
   );
 
-  for (let gameObj of player.getNearbyGameObjects(state)) {
+  for (let gameObj of player.getNearbyGameObjects(state, true)) {
     if (gameObj.isPlayerGameObject() && collidePlayerGameObject(player, gameObj)) {
+      if (!player.client?.seenGameObjects.includes(gameObj.id)) {
+        player.client?.socket.send(
+          packetFactory.serializePacket(
+            new Packet(PacketType.LOAD_GAME_OBJ, [gameObj.getData()])
+          )
+        );
+
+        player.client?.seenGameObjects.push(gameObj.id);
+      }
+
       if (
         gameObj.data === ItemType.PitTrap &&
         gameObj.isEnemy(player, state.tribes)

src/moomoo/Player.ts

@@ -19,7 +19,8 @@ import {
   getGameObjID,
   getGameObjHealth,
   getGameObjPlaceLimit,
-  getGroupID
+  getGroupID,
+  shouldHideFromEnemy
 } from "../items/items";
 import { ItemType } from "../items/UpgradeItems";
 import GameObject from "../gameobjects/GameObject";
@@ -408,7 +409,7 @@ export default class Player extends Entity {
     }
   }
 
-  public getNearbyGameObjects(state: GameState) {
+  public getNearbyGameObjects(state: GameState, includeHidden = false) {
     const RADIUS = process.env.GAMEOBJECT_NEARBY_RADIUS || 1250;
 
     let gameObjects = [];
@@ -420,7 +421,13 @@ export default class Player extends Entity {
           [gameObject.location.x, gameObject.location.y]
         ) < RADIUS
       ) {
-        gameObjects.push(gameObject);
+        if (
+          !(gameObject.isPlayerGameObject() &&
+            shouldHideFromEnemy(gameObject.data) &&
+            gameObject.isEnemy(this, state.tribes)) || includeHidden
+        ) {
+          gameObjects.push(gameObject);
+        }
       }
     }