Skip to content

Commit 399a09c

Browse files
yinyihu-silabsPeterC1965
authored andcommitted
fix project-chip#35210: tc-icdm-2.1, 3.1, 3.4 (project-chip#35227)
* fix 35210: tc-icdm-2.1, 3.1, 3.4 * missing changes.
1 parent 30b8027 commit 399a09c

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

src/python_testing/TC_ICDM_2_1.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ def desc_TC_ICDM_2_1(self) -> str:
9696

9797
def steps_TC_ICDM_2_1(self) -> list[TestStep]:
9898
steps = [
99-
TestStep(1, "Commissioning, already done", is_commissioning=True),
99+
TestStep("1a", "Commissioning, already done", is_commissioning=True),
100+
TestStep("1b", "CTH reads from the DUT the FeatureMap attribute."),
100101
TestStep(2, "TH reads from the DUT the ActiveModeThreshold attribute."),
101102
TestStep(3, "TH reads from the DUT the ActiveModeDuration attribute."),
102103
TestStep(4, "TH reads from the DUT the IdleModeDuration attribute."),
@@ -131,8 +132,9 @@ async def test_TC_ICDM_2_1(self):
131132
attributes = cluster.Attributes
132133

133134
# Commissioning
134-
self.step(1)
135+
self.step("1a")
135136
# Read feature map
137+
self.step("1b")
136138
featureMap = await self._read_icdm_attribute_expect_success(
137139
attributes.FeatureMap)
138140

src/python_testing/TC_ICDM_3_1.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def steps_TC_ICDM_3_1(self) -> list[TestStep]:
8585
TestStep(7, "TTH sends UnregisterClient command with the CheckInNodeID from Step 6."),
8686
TestStep(8, "TH sends UnregisterClient command with the CheckInNodeID from Step 2."),
8787
TestStep(9, "TH reads from the DUT the RegisteredClients attribute."),
88-
TestStep(10, "Repeat Step 9 with the rest of CheckInNodeIDs from the list of RegisteredClients from Step 4, if any."),
88+
TestStep(10, "Repeat Step 8-9 with the rest of CheckInNodeIDs from the list of RegisteredClients from Step 4, if any."),
8989
TestStep(11, "TH reads from the DUT the RegisteredClients attribute."),
9090
TestStep(12, "TH sends UnregisterClient command with the CheckInNodeID from Step 2."),
9191
]
@@ -240,6 +240,11 @@ async def test_TC_ICDM_3_1(self):
240240
e.status, Status.Success, "Unexpected error returned")
241241
pass
242242

243+
registeredClients = await self._read_icdm_attribute_expect_success(attributes.RegisteredClients)
244+
for remainingClient in registeredClients:
245+
asserts.assert_not_equal(remainingClient.checkInNodeID, client["checkInNodeID"],
246+
"CheckInNodeID was unregistered. It should not be present in the attribute list.")
247+
243248
self.step(11)
244249
registeredClients = await self._read_icdm_attribute_expect_success(
245250
attributes.RegisteredClients)

src/python_testing/TC_ICDM_3_4.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def steps_TC_ICDM_3_4(self) -> list[TestStep]:
6363
steps = [
6464
TestStep(0, "Commissioning, already done", is_commissioning=True),
6565
TestStep(1, "TH reads from the DUT the ICDCounter attribute."),
66-
TestStep("2a", "Reboot DUT."),
66+
TestStep("2a", "Power cycle DUT."),
6767
TestStep("2b", "TH waits for {PIXIT.WAITTIME.REBOOT}"),
6868
TestStep(3, "Verify that the DUT response contains value of ICDCounter and stores in IcdCounter2. \
6969
IcdCounter2 is greater or equal to IcdCounter1. \

0 commit comments

Comments
 (0)