Add mkdir_p function #459
Merged
Add mkdir_p function #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Oct 31, 2017
doc/autoscale/example/convert.py
Outdated
| def mkdir_p(path): | ||
| try: | ||
| os.makedirs(path) | ||
| except OSError as exc: # Python >2.5 |
There was a problem hiding this comment.
We don't intend to support Python <2.5, so we always run into except branch.
There was a problem hiding this comment.
是说，应该都不会考虑支持python 2.5以下的版本，所以是否try里的代码都不会被执行到呢。
There was a problem hiding this comment.
那句话的意思是Python>2.5才能执行到。我还是删除掉注释吧。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #460