[clang-tidy] enable bugprone-exception-escape check (#56692)

gouzil · web-flow · commit dcaca0f47808 · 2023-08-28T16:51:29.000+08:00
diff --git a/.clang-tidy b/.clang-tidy
@@ -8,7 +8,7 @@ bugprone-argument-comment,
 bugprone-copy-constructor-init,
 -bugprone-dangling-handle,
 -bugprone-dynamic-static-initializers,
--bugprone-exception-escape,
+bugprone-exception-escape,
 -bugprone-fold-init-type,
 -bugprone-forwarding-reference-overload,
 -bugprone-inaccurate-erase,
diff --git a/paddle/fluid/distributed/auto_parallel/spmd_rules/dim_trans.cc b/paddle/fluid/distributed/auto_parallel/spmd_rules/dim_trans.cc
@@ -72,7 +72,7 @@ Flatten::Flatten(const std::vector<DimTrans*>& dims)
   all_dim_trans.emplace_back(this);
 }
 
-Flatten::~Flatten() {
+Flatten::~Flatten() {  // NOLINT
   input_dims_.assign(input_dims_.size(), nullptr);
   std::vector<DimTrans*>().swap(input_dims_);
 }
diff --git a/paddle/fluid/eager/auto_code_generator/eager_generator.cc b/paddle/fluid/eager/auto_code_generator/eager_generator.cc
@@ -3299,7 +3299,7 @@ static void DygraphCodeGeneration(const std::string& output_dir,
 }  // namespace framework
 }  // namespace paddle
 
-int main(int argc, char* argv[]) {
+int main(int argc, char* argv[]) {  // NOLINT
   if (argc != 3) {
     std::cerr << "argc must be 3" << std::endl;
     return -1;
diff --git a/paddle/fluid/eager/pylayer/py_layer_node.cc b/paddle/fluid/eager/pylayer/py_layer_node.cc
@@ -27,7 +27,7 @@
 #include "pybind11/pytypes.h"
 
 namespace egr {
-GradNodePyLayer::~GradNodePyLayer() {
+GradNodePyLayer::~GradNodePyLayer() {  // NOLINT
   pybind11::gil_scoped_acquire gil;
   Py_XDECREF(ctx_);
 }
diff --git a/paddle/fluid/framework/custom_operator.cc b/paddle/fluid/framework/custom_operator.cc
@@ -916,11 +916,12 @@ static void RegisterOperatorKernel(
   OperatorWithKernel::OpKernelFunc op_kernel_func;
   if (kernel_func) {
     VLOG(3) << "Register custom operator " << name << " with kernel func";
-    op_kernel_func = [kernel_func, inputs, outputs, attrs, inplace_map](
-                         const framework::ExecutionContext& ctx) {
-      VLOG(3) << "Custom Operator: run custom kernel func in lambda.";
-      RunKernelFunc(ctx, kernel_func, inputs, outputs, attrs, inplace_map);
-    };
+    op_kernel_func =
+        [kernel_func, inputs, outputs, attrs, inplace_map](  // NOLINT
+            const framework::ExecutionContext& ctx) {
+          VLOG(3) << "Custom Operator: run custom kernel func in lambda.";
+          RunKernelFunc(ctx, kernel_func, inputs, outputs, attrs, inplace_map);
+        };
   } else {
     VLOG(3) << "Register custom operator " << name
             << " with raw op kernel func";
@@ -1027,12 +1028,12 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
   // InferShape
   if (infer_shape_func == nullptr) {
     // use default InferShape
-    info.infer_shape_ =
-        [op_inputs, op_outputs, op_inplace_map](InferShapeContext* ctx) {
-          RunDefaultInferShapeFunc(ctx, op_inputs, op_outputs, op_inplace_map);
-        };
+    info.infer_shape_ = [op_inputs, op_outputs, op_inplace_map](  // NOLINT
+                            InferShapeContext* ctx) {
+      RunDefaultInferShapeFunc(ctx, op_inputs, op_outputs, op_inplace_map);
+    };
   } else {
-    info.infer_shape_ = [op_inputs,
+    info.infer_shape_ = [op_inputs,  // NOLINT
                          op_outputs,
                          op_attrs,
                          op_inplace_map,
@@ -1051,12 +1052,12 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
   // Infer Dtype
   if (infer_dtype_func == nullptr) {
     // use default InferDtype
-    info.infer_var_type_ =
-        [op_inputs, op_outputs, op_inplace_map](InferVarTypeContext* ctx) {
-          RunDefaultInferDtypeFunc(ctx, op_inputs, op_outputs, op_inplace_map);
-        };
+    info.infer_var_type_ = [op_inputs, op_outputs, op_inplace_map](  // NOLINT
+                               InferVarTypeContext* ctx) {
+      RunDefaultInferDtypeFunc(ctx, op_inputs, op_outputs, op_inplace_map);
+    };
   } else {
-    info.infer_var_type_ = [op_inputs,
+    info.infer_var_type_ = [op_inputs,  // NOLINT
                             op_outputs,
                             op_attrs,
                             op_inplace_map,
@@ -1115,7 +1116,10 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
 
     // GradOpDescMaker
     info.grad_op_maker_ =
-        [grad_op_name, grad_op_inputs, grad_op_outputs, is_double_grad](
+        [grad_op_name,  // NOLINT
+         grad_op_inputs,
+         grad_op_outputs,
+         is_double_grad](
             const OpDesc& fwd_op,
             const std::unordered_set<std::string>& no_grad_set,
             std::unordered_map<std::string, std::string>* grad_to_var,
@@ -1133,7 +1137,10 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
 
     // GradOpBaseMaker
     info.dygraph_grad_op_maker_ =
-        [grad_op_name, grad_op_inputs, grad_op_outputs, is_double_grad](
+        [grad_op_name,  // NOLINT
+         grad_op_inputs,
+         grad_op_outputs,
+         is_double_grad](
             const std::string& type,
             const imperative::NameVarBaseMap& var_base_map_in,
             const imperative::NameVarBaseMap& var_base_map_out,
@@ -1173,7 +1180,7 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
 
     // Grad InferShape
     if (grad_infer_shape_fn == nullptr) {
-      grad_info.infer_shape_ = [grad_op_inputs,
+      grad_info.infer_shape_ = [grad_op_inputs,  // NOLINT
                                 grad_op_outputs,
                                 is_double_grad](InferShapeContext* ctx) {
         // 1. if forward input exists, gradient's shape is same with forward
@@ -1211,7 +1218,7 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
         }
       };
     } else {
-      grad_info.infer_shape_ = [grad_op_inputs,
+      grad_info.infer_shape_ = [grad_op_inputs,  // NOLINT
                                 grad_op_outputs,
                                 grad_op_attrs,
                                 grad_op_inplace_map,
@@ -1230,7 +1237,7 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
     // Grad InferDtype
     if (grad_infer_dtype_fn != nullptr) {
       grad_info.infer_var_type_ =
-          [grad_op_inputs,
+          [grad_op_inputs,  // NOLINT
            grad_op_outputs,
            grad_op_attrs,
            grad_op_inplace_map,
diff --git a/paddle/fluid/framework/new_executor/interpreter/interpreter_util.cc b/paddle/fluid/framework/new_executor/interpreter/interpreter_util.cc
@@ -72,7 +72,7 @@ class SingleStreamGuard {
     }
   }
 
-  ~SingleStreamGuard() {
+  ~SingleStreamGuard() {  // NOLINT
     if (!is_changed) {
       return;
     }
diff --git a/paddle/fluid/framework/scope.cc b/paddle/fluid/framework/scope.cc
@@ -33,7 +33,7 @@ PADDLE_DEFINE_EXPORTED_bool(
 namespace paddle {
 namespace framework {
 
-Scope::~Scope() { DropKids(); }
+Scope::~Scope() { DropKids(); }  // NOLINT
 
 Scope& Scope::NewScope() const {
   Scope* child = new Scope(this);
diff --git a/paddle/fluid/inference/api/analysis_predictor.cc b/paddle/fluid/inference/api/analysis_predictor.cc
@@ -2581,7 +2581,7 @@ bool AnalysisPredictor::SaveTrtCalibToDisk() {
 }
 #endif
 
-AnalysisPredictor::~AnalysisPredictor() {
+AnalysisPredictor::~AnalysisPredictor() {  // NOLINT
 #ifdef PADDLE_WITH_TENSORRT
   if (config_.tensorrt_engine_enabled() &&
       config_.tensorrt_precision_mode_ == AnalysisConfig::Precision::kInt8 &&
diff --git a/paddle/fluid/memory/allocation/mmap_allocator.cc b/paddle/fluid/memory/allocation/mmap_allocator.cc
@@ -391,7 +391,7 @@ void MemoryMapAllocationPool::Clear() {
   memory_map_allocations_.clear();
 }
 
-MemoryMapAllocationPool::~MemoryMapAllocationPool() { Clear(); }
+MemoryMapAllocationPool::~MemoryMapAllocationPool() { Clear(); }  // NOLINT
 
 }  // namespace allocation
 }  // namespace memory
diff --git a/paddle/fluid/platform/profiler.cc b/paddle/fluid/platform/profiler.cc
@@ -591,7 +591,7 @@ MemEvenRecorder::RecordMemEvent::RecordMemEvent(const Place &place,
   PushMemEvent(start_ns_, end_ns_, bytes_, place_, alloc_in_);
 }
 
-MemEvenRecorder::RecordMemEvent::~RecordMemEvent() {
+MemEvenRecorder::RecordMemEvent::~RecordMemEvent() {  // NOLINT
   phi::DeviceTracer *tracer = phi::GetDeviceTracer();
   end_ns_ = PosixInNsec();
 
diff --git a/paddle/fluid/platform/profiler/chrometracing_logger.cc b/paddle/fluid/platform/profiler/chrometracing_logger.cc
@@ -60,7 +60,7 @@ ChromeTracingLogger::ChromeTracingLogger(const char* filename_cstr) {
   StartLog();
 }
 
-ChromeTracingLogger::~ChromeTracingLogger() {
+ChromeTracingLogger::~ChromeTracingLogger() {  // NOLINT
   EndLog();
   output_file_stream_.close();
 }
diff --git a/paddle/fluid/platform/profiler/dump/deserialization_reader.cc b/paddle/fluid/platform/profiler/dump/deserialization_reader.cc
@@ -150,7 +150,7 @@ std::unique_ptr<ProfilerResult> DeserializationReader::Parse() {
   return std::unique_ptr<ProfilerResult>(profiler_result_ptr);
 }
 
-DeserializationReader::~DeserializationReader() {
+DeserializationReader::~DeserializationReader() {  // NOLINT
   delete node_trees_proto_;
   input_file_stream_.close();
 }
diff --git a/paddle/fluid/platform/profiler/dump/serialization_logger.cc b/paddle/fluid/platform/profiler/dump/serialization_logger.cc
@@ -371,7 +371,7 @@ SerializationLogger::SerializationLogger(const char* filename_cstr) {
   OpenFile();
 }
 
-SerializationLogger::~SerializationLogger() {
+SerializationLogger::~SerializationLogger() {  // NOLINT
   if (!output_file_stream_) {
     delete node_trees_proto_;
     return;
diff --git a/paddle/fluid/pybind/eager_functions.cc b/paddle/fluid/pybind/eager_functions.cc
@@ -106,7 +106,7 @@ class EagerNumpyAllocation : public phi::Allocation {
             "The underlying PyObject pointer of numpy array cannot be None"));
     Py_INCREF(arr_);
   }
-  ~EagerNumpyAllocation() override {
+  ~EagerNumpyAllocation() override {  // NOLINT
     py::gil_scoped_acquire gil;
     Py_DECREF(arr_);
   }
diff --git a/paddle/fluid/pybind/eager_legacy_op_function_generator.cc b/paddle/fluid/pybind/eager_legacy_op_function_generator.cc
@@ -477,7 +477,7 @@ GenerateOpFunctions() {
   return std::make_tuple(op_function_list, bind_function_list);
 }
 
-int main(int argc, char* argv[]) {
+int main(int argc, char* argv[]) {  // NOLINT
   if (argc != 2) {
     std::cerr << "argc must be 2" << std::endl;
     return -1;
diff --git a/paddle/fluid/pybind/eager_utils.cc b/paddle/fluid/pybind/eager_utils.cc
@@ -1834,7 +1834,7 @@ void PyVoidHook::operator()() {
 
 PyObjectHolder::PyObjectHolder(PyObject* ptr) { ptr_ = ptr; }
 
-PyObjectHolder::~PyObjectHolder() {
+PyObjectHolder::~PyObjectHolder() {  // NOLINT
   ::pybind11::gil_scoped_acquire gil;
   Py_XDECREF(ptr_);
 }
@@ -1860,7 +1860,7 @@ void PyObjectHolder::dec_ref() {
 
 PackHook::PackHook(PyObject* hook) : hook_(hook) { Py_INCREF(hook_); }
 
-PackHook::~PackHook() {
+PackHook::~PackHook() {  // NOLINT
   ::pybind11::gil_scoped_acquire gil;
   Py_DECREF(hook_);
 }
@@ -1899,7 +1899,7 @@ void* PackHook::operator()(void* py_tensor) {
 
 UnPackHook::UnPackHook(PyObject* hook) : hook_(hook) { Py_INCREF(hook_); }
 
-UnPackHook::~UnPackHook() {
+UnPackHook::~UnPackHook() {  // NOLINT
   ::pybind11::gil_scoped_acquire gil;
   Py_DECREF(hook_);
 }
diff --git a/paddle/fluid/pybind/imperative.cc b/paddle/fluid/pybind/imperative.cc
@@ -88,7 +88,7 @@ class PyVariableWrapperHook : public imperative::VariableWrapperHook {
     Py_INCREF(py_func_);
   }
 
-  ~PyVariableWrapperHook() override {
+  ~PyVariableWrapperHook() override {  // NOLINT
     py::gil_scoped_acquire gil;
     Py_DECREF(py_func_);
   }
diff --git a/paddle/fluid/pybind/kernel_signature_generator.cc b/paddle/fluid/pybind/kernel_signature_generator.cc
@@ -40,7 +40,7 @@
 // },
 // ...
 // }
-int main(int argc, char **argv) {
+int main(int argc, char **argv) {  // NOLINT
   paddle::framework::InitDefaultKernelSignatureMap();
   auto &kernel_signature_map = phi::DefaultKernelSignatureMap::Instance();
   auto &kernel_factory = phi::KernelFactory::Instance();
diff --git a/paddle/ir/core/storage_manager.cc b/paddle/ir/core/storage_manager.cc
@@ -28,7 +28,7 @@ struct ParametricStorageManager {
   explicit ParametricStorageManager(std::function<void(StorageBase *)> destroy)
       : destroy_(destroy) {}
 
-  ~ParametricStorageManager() {
+  ~ParametricStorageManager() {  // NOLINT
     for (const auto &instance : parametric_instances_) {
       destroy_(instance.second);
     }
diff --git a/paddle/phi/core/distributed/store/tcp_store.cc b/paddle/phi/core/distributed/store/tcp_store.cc
@@ -43,7 +43,7 @@ MasterDaemon::MasterDaemon(SocketType socket, int nranks, int timeout)
   _background_thread = std::thread{&MasterDaemon::run, this};
 }
 
-MasterDaemon::~MasterDaemon() {
+MasterDaemon::~MasterDaemon() {  // NOLINT
   VLOG(4) << ("begin to destruct MasterDaemon");
   StopByControlFd();
   _background_thread.join();
diff --git a/paddle/phi/core/sparse_coo_tensor.cc b/paddle/phi/core/sparse_coo_tensor.cc
@@ -21,7 +21,7 @@ SparseCooTensor::SparseCooTensor() {
   this->SetMember(non_zero_indices, non_zero_elements, {1}, true);
 }
 
-SparseCooTensor::SparseCooTensor(SparseCooTensor&& other) {
+SparseCooTensor::SparseCooTensor(SparseCooTensor&& other) {  // NOLINT
   this->non_zero_elements_ = other.non_zero_elements_;
   this->non_zero_indices_ = other.non_zero_indices_;
   this->coalesced_ = other.coalesced_;
diff --git a/paddle/phi/core/string_tensor.cc b/paddle/phi/core/string_tensor.cc
@@ -48,7 +48,7 @@ StringTensor& StringTensor::operator=(const StringTensor& other) {
   return *this;
 }
 
-StringTensor& StringTensor::operator=(StringTensor&& other) {
+StringTensor& StringTensor::operator=(StringTensor&& other) {  // NOLINT
   meta_ = std::move(other.meta_);
   std::swap(holder_, other.holder_);
   return *this;
diff --git a/paddle/phi/core/tensor_meta.cc b/paddle/phi/core/tensor_meta.cc
@@ -183,7 +183,8 @@ DenseTensorMeta& DenseTensorMeta::operator=(const DenseTensorMeta& other) {
   return *this;
 }
 
-DenseTensorMeta& DenseTensorMeta::operator=(DenseTensorMeta&& other) {
+DenseTensorMeta& DenseTensorMeta::operator=(  // NOLINT
+    DenseTensorMeta&& other) {
   is_scalar = other.is_scalar;
   use_gpudnn = other.use_gpudnn;
   dims = std::move(other.dims);
diff --git a/paddle/testing/paddle_gtest_main.cc b/paddle/testing/paddle_gtest_main.cc
@@ -23,7 +23,7 @@ limitations under the License. */
 DECLARE_bool(enable_gpu_memory_usage_log);
 #endif
 
-int main(int argc, char** argv) {
+int main(int argc, char** argv) {  // NOLINT
   paddle::memory::allocation::UseAllocatorStrategyGFlag();
   testing::InitGoogleTest(&argc, argv);
   std::vector<char*> new_argv;

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ Flatten::Flatten(const std::vector<DimTrans*>& dims)`
`72`	`72`	`all_dim_trans.emplace_back(this);`
`73`	`73`	`}`
`74`	`74`
`75`		`-Flatten::~Flatten() {`
	`75`	`+Flatten::~Flatten() { // NOLINT`
`76`	`76`	`input_dims_.assign(input_dims_.size(), nullptr);`
`77`	`77`	`std::vector<DimTrans*>().swap(input_dims_);`
`78`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`#include "pybind11/pytypes.h"`
`28`	`28`
`29`	`29`	`namespace egr {`
`30`		`-GradNodePyLayer::~GradNodePyLayer() {`
	`30`	`+GradNodePyLayer::~GradNodePyLayer() { // NOLINT`
`31`	`31`	`pybind11::gil_scoped_acquire gil;`
`32`	`32`	`Py_XDECREF(ctx_);`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ class SingleStreamGuard {`
`72`	`72`	`}`
`73`	`73`	`}`
`74`	`74`
`75`		`- ~SingleStreamGuard() {`
	`75`	`+ ~SingleStreamGuard() { // NOLINT`
`76`	`76`	`if (!is_changed) {`
`77`	`77`	`return;`
`78`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2581,7 +2581,7 @@ bool AnalysisPredictor::SaveTrtCalibToDisk() {`
`2581`	`2581`	`}`
`2582`	`2582`	`#endif`
`2583`	`2583`
`2584`		`-AnalysisPredictor::~AnalysisPredictor() {`
	`2584`	`+AnalysisPredictor::~AnalysisPredictor() { // NOLINT`
`2585`	`2585`	`#ifdef PADDLE_WITH_TENSORRT`
`2586`	`2586`	`if (config_.tensorrt_engine_enabled() &&`
`2587`	`2587`	`config_.tensorrt_precision_mode_ == AnalysisConfig::Precision::kInt8 &&`
Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,7 @@ void MemoryMapAllocationPool::Clear() {`
`391`	`391`	`memory_map_allocations_.clear();`
`392`	`392`	`}`
`393`	`393`
`394`		`-MemoryMapAllocationPool::~MemoryMapAllocationPool() { Clear(); }`
	`394`	`+MemoryMapAllocationPool::~MemoryMapAllocationPool() { Clear(); } // NOLINT`
`395`	`395`
`396`	`396`	`} // namespace allocation`
`397`	`397`	`} // namespace memory`
Original file line number	Diff line number	Diff line change
`@@ -591,7 +591,7 @@ MemEvenRecorder::RecordMemEvent::RecordMemEvent(const Place &place,`
`591`	`591`	`PushMemEvent(start_ns_, end_ns_, bytes_, place_, alloc_in_);`
`592`	`592`	`}`
`593`	`593`
`594`		`-MemEvenRecorder::RecordMemEvent::~RecordMemEvent() {`
	`594`	`+MemEvenRecorder::RecordMemEvent::~RecordMemEvent() { // NOLINT`
`595`	`595`	`phi::DeviceTracer *tracer = phi::GetDeviceTracer();`
`596`	`596`	`end_ns_ = PosixInNsec();`
`597`	`597`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ ChromeTracingLogger::ChromeTracingLogger(const char* filename_cstr) {`
`60`	`60`	`StartLog();`
`61`	`61`	`}`
`62`	`62`
`63`		`-ChromeTracingLogger::~ChromeTracingLogger() {`
	`63`	`+ChromeTracingLogger::~ChromeTracingLogger() { // NOLINT`
`64`	`64`	`EndLog();`
`65`	`65`	`output_file_stream_.close();`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ std::unique_ptr<ProfilerResult> DeserializationReader::Parse() {`
`150`	`150`	`return std::unique_ptr<ProfilerResult>(profiler_result_ptr);`
`151`	`151`	`}`
`152`	`152`
`153`		`-DeserializationReader::~DeserializationReader() {`
	`153`	`+DeserializationReader::~DeserializationReader() { // NOLINT`
`154`	`154`	`delete node_trees_proto_;`
`155`	`155`	`input_file_stream_.close();`
`156`	`156`	`}`
Original file line number	Diff line number	Diff line change
`@@ -371,7 +371,7 @@ SerializationLogger::SerializationLogger(const char* filename_cstr) {`
`371`	`371`	`OpenFile();`
`372`	`372`	`}`
`373`	`373`
`374`		`-SerializationLogger::~SerializationLogger() {`
	`374`	`+SerializationLogger::~SerializationLogger() { // NOLINT`
`375`	`375`	`if (!output_file_stream_) {`
`376`	`376`	`delete node_trees_proto_;`
`377`	`377`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ class EagerNumpyAllocation : public phi::Allocation {`
`106`	`106`	`"The underlying PyObject pointer of numpy array cannot be None"));`
`107`	`107`	`Py_INCREF(arr_);`
`108`	`108`	`}`
`109`		`- ~EagerNumpyAllocation() override {`
	`109`	`+ ~EagerNumpyAllocation() override { // NOLINT`
`110`	`110`	`py::gil_scoped_acquire gil;`
`111`	`111`	`Py_DECREF(arr_);`
`112`	`112`	`}`